Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket_8284_Allow_certain_values_to_be_editable_without_restarting_IOC #843

Conversation

isaachilly
Copy link
Contributor

Description of work

Added a MACRO for the McLennan IOC that allows a user to be able to set the ASG group of the MOTOR record. The ASG group controls what ASLs (either 1 or 0) are allowed to do I.E (1, read) allows pvs with ASL 1 to be read etc. This concept was used here to allow user to set the JVEL, HLM and LLM without having to change them in the IOC macro screen and thus have to restart the IOC. If they set the MOTOR_ASG to DEFAULT and then start/restart the IOC it means the access control is set to read & write.

To test

  • Check the code's quality
  • Check tests are written correctly and pass
  • Set (or don't set) MOTOR_ASG manually in your globals.txt and check functionality by spinning up McLennan IOC using C:\Instrument\Apps\EPICS\support\IocTestFramework\master>run_all_tests.bat -t mclennan -a. Remember to let tests run through before ctrl-c otherwise you have to find the procserve process in task manager details and end that before you can start up the IOC again

Acceptance criteria

  • A security group is created that allows for the JVEL, HLM, and LLM to be set or not based on a specific macro which defaults to not allowing changes
  • There are tests both with and without that macro set to ensure the beaviour is as expected

Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@zsoltkebel zsoltkebel merged commit 0a5042b into master Apr 18, 2024
@zsoltkebel zsoltkebel deleted the Ticket_8284_Allow_certain_values_to_be_editable_without_restarting_IOC branch April 18, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants