Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mclennan: Allow certain values to be made available to edit without restarting the IOC #8284

Closed
2 tasks
KathrynBaker opened this issue Apr 3, 2024 · 1 comment
Assignees
Labels

Comments

@KathrynBaker
Copy link
Member

KathrynBaker commented Apr 3, 2024

As a scientist using the Mclennan there are times when I want to be able to edit the Jog velocity as well as the high and low limits, as these are not readily editable as the places to change them are non-persisting I would like a macro to let me make this change anyway that can be set in globals.txt.

Acceptance Criteria

  • A security group is created that allows for the JVEL, HLM, and LLM to be set or not based on a specific macro which defaults to not allowing changes
  • There are tests both with and without that macro set to ensure the beaviour is as expected

Extra Information

  • Selective access security for certain fields is already present in Mclennans, look at how it's already being done and extend it with macros

How to Test

verbose instructions for reviewer to test changes
(Add before making a PR)

Time in planning

1:42:45 4/4/24

@isaachilly
Copy link
Contributor

isaachilly commented Apr 12, 2024

PRs

To test

  • Checkout all branches
  • Check the code's quality
  • Check tests are written correctly and pass
  • Set (or don't set) MOTOR_ASG manually in your globals.txt and check functionality by spinning up McLennan IOC using C:\Instrument\Apps\EPICS\support\IocTestFramework\master>run_all_tests.bat -t mclennan -a. Remember to let tests run through before ctrl-c otherwise you have to find the procserve process in task manager details and end that before you can start up the IOC again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants