Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mclennan: Indicate on the low level motor screen when non-persisting changes can be made to JVEL, HLM, and LLM #8285

Closed
1 task done
KathrynBaker opened this issue Apr 3, 2024 · 2 comments · Fixed by ISISComputingGroup/ibex_gui#1695 or #8304
Assignees
Labels

Comments

@KathrynBaker
Copy link
Member

KathrynBaker commented Apr 3, 2024

As someone wanting to override the settings which means I can allow changes to motor values that won't persist I want to be reminded that this is the case.

Acceptance Criteria

What is the acceptance criteria?

Extra Information

  • Whilst the basic functionality can be generated and patched, the initial limitation was created because the values set here do not persist for Mclennans, with an override in place, this ought to be highlighted on the motor screen.
  • Already do this with Auto enabling and servo PID

How to Test

verbose instructions for reviewer to test changes
(Add before making a PR)

Time in planning

1:42:45 4/4/24

@KathrynBaker
Copy link
Member Author

KathrynBaker commented Apr 3, 2024

The message should appear somewhere on this screen as a text label:

Image

@LowriJenkins LowriJenkins added the 3 label Apr 4, 2024
@KathrynBaker KathrynBaker moved this to Backlog in PI_2024_02 Apr 4, 2024
@github-actions github-actions bot added the ready label Apr 4, 2024
@KathrynBaker KathrynBaker added this to the SPRINT_2024_04_04 milestone Apr 4, 2024
@zsoltkebel zsoltkebel self-assigned this Apr 18, 2024
@zsoltkebel
Copy link
Contributor

image

Added a label that displays warning when the motor is a Mclennan and the security group is set to DEFAULT. DEFAULT is the broadest so the assumption is that any other future groups would be more restrictive.

@KathrynBaker KathrynBaker moved this from Backlog to In Progress in PI_2024_02 Apr 19, 2024
@zsoltkebel zsoltkebel linked a pull request Apr 19, 2024 that will close this issue
7 tasks
@zsoltkebel zsoltkebel mentioned this issue Apr 19, 2024
@zsoltkebel zsoltkebel linked a pull request Apr 19, 2024 that will close this issue
@KathrynBaker KathrynBaker moved this from In Progress to Review in PI_2024_02 Apr 22, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PI_2024_02 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants