Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning label #1695

Conversation

zsoltkebel
Copy link
Contributor

@zsoltkebel zsoltkebel commented Apr 19, 2024

Description of work

Added a warning label that notifies the user that motor values can be changed but won't persist.

Meaningful changes start at line 3971. The other changes are due to styling differences.

Ticket

ISISComputingGroup/IBEX#8285

Acceptance criteria

  • The label is shown when the global macro MOTOR_ASG is set to DEFAULT.
  • It is not shown if the macro is not set or set to WASL0.

Code Review

Final Steps

Copy link
Contributor

@esmith1729 esmith1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@esmith1729 esmith1729 merged commit 0828d65 into master Apr 23, 2024
1 check passed
@esmith1729 esmith1729 deleted the ticket8285-indicate-when-non-persistent-changes-available-mclennan-opi branch April 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mclennan: Indicate on the low level motor screen when non-persisting changes can be made to JVEL, HLM, and LLM
2 participants