Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define svd #20

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Define svd #20

merged 2 commits into from
Jan 17, 2025

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Jan 17, 2025

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 32.68%. Comparing base (eab2fec) to head (c261918).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tensoralgebra.jl 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   34.01%   32.68%   -1.34%     
==========================================
  Files          14       14              
  Lines         638      664      +26     
==========================================
  Hits          217      217              
- Misses        421      447      +26     
Flag Coverage Δ
docs 32.57% <0.00%> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman
Copy link
Member Author

mtfishman commented Jan 17, 2025

@lkdvos this is meant as a starting point, we'll need to add truncation, check that it works with block sparse arrays (now that ITensor/BlockSparseArrays.jl#16 is merged), etc. Part of my reason for rushing this a bit is so that I can test out some ITensorMPS.jl code that makes use of SVD. Also I think it is good to have a starting point in place to work with, even if we don't get all of the corner cases handled right now.

@mtfishman mtfishman merged commit 920f4c3 into main Jan 17, 2025
10 of 12 checks passed
@mtfishman mtfishman deleted the factorizations branch January 17, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant