Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define TensorAlgebra.svd, define TensorAlgebra.qr rather than overloading LinearAlgebra.qr #20

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

mtfishman
Copy link
Member

Fixes #5.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (4453f64) to head (6ddc169).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   91.66%   93.92%   +2.25%     
==========================================
  Files          16       15       -1     
  Lines         360      362       +2     
==========================================
+ Hits          330      340      +10     
+ Misses         30       22       -8     
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman merged commit 9c547b6 into main Jan 17, 2025
12 checks passed
@mtfishman mtfishman deleted the factorizations branch January 17, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] qr(::AbstractArray, ::Tuple, ::Tuple, ::Tuple) is a large source of ambiguities and type piracy
1 participant