-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggest: edit sequence and description tautomerism options #65
Comments
Thanks Djordje
Gerd
Von: Djordje Baljozovic ***@***.***>
Gesendet: Donnerstag, 24. Oktober 2024 21:20
An: IUPAC-InChI/InChI ***@***.***>
Cc: ***@***.***; Assign ***@***.***>
Betreff: Re: [IUPAC-InChI/InChI] suggest: edit sequence and description tautomerism options (Issue #65)
Assigned #65<#65> to @gblanke02<https://github.com/gblanke02>.
—
Reply to this email directly, view it on GitHub<#65 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AT3EDCNQDYCCJZSYF2YG4CLZ5FB4NAVCNFSM6AAAAABQRAIZKOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUHA2TONJTHA3DKOI>.
You are receiving this because you were assigned.Message ID: ***@***.******@***.***>>
|
Thank you for reporting this and suggesting directly a solution! This shows once again that it was the right step to move the project to GitHub and make it more accessible to the community. I like your suggestions and will check the status of PS: The web demo loads longer since it is hosted on the users machine. So all your input stays local and private. @gblanke02 @djb-rwth Please correct me if I am wrong. |
@fbaensch-beilstein Indeed, after the sample page is loaded once, it is possible to detach the LAN cable and still assign new structures an InChI. It equally was possible to the toggle to RInChI for the assignment of reactions, too. @kiddr If there is a confirmation by @gblanke02 or/and @djb-rwth that every action subsequent to loading the page remains local, I propose to add a disclaimer to the we site -- between the line of the header, and the tabs to select either tab Hopefully someone with more experience in marketing than I can improve the wording: |
@flange-ipb I think this is your responsibility. |
Hi @nbehrnd, |
@djb-rwth Ok, the additional suggest was moved. |
@nbehrnd All options relating to tautomerism are still in the experimental stage and under development. A separate ‘tautomer release’ is planned for the future, but this will be separate from the standard InChI. |
@djb-rwth Thank you for providing the update.
|
Hi @nbehrnd,
Yes. Regression tests using
This is something that @gblanke02 and @fbaensch-beilstein should look into. I will correct this accordingly in the final version of |
For future version 1.07.2, I would like to suggest to edit the sequence and description of tautomerism options in the reference executable.
The reference executable (v1.07.1, 64bit, Linux) lists processing tautomerism as optional features with
I would prefer if the sequence of the list were in sync with the sequence of the test page* and provide a brief note, for instance
The substitution of
Account for
for the shorter stringconsider
aims for a compact output to the CLI calling the executable. By similar reasoning, stringPT_06
as a flag seems to fully suffice to identify the corresponding rule in its reference (presumably 2020JChemInf1090, link to NIH copy). None of these six newly implemented rules actually represent a mm variant; nevertheless, the corresponding description mentions the complete string (e.g.PT_06_00
).Because
KET
and15T
already were provided by the executable version 1.6 (published December 2022) and 1.3 (June 2010) I wonder if these two rules still are considered experimental in 2024. In the proposal above, I dropped the idea of labeling them as optional instead, because usage of every entry in section ofCustomizing InChI creation
is optional.* Is it only for me that the sketcher/the page takes longer to start-up/become responsive again to draw a molecule compared to the sketchers e.g., Reaxys, COD, Sigma Aldrich etc. deploy?
The text was updated successfully, but these errors were encountered: