Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid parsing of the bool arguments #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mic4ael
Copy link

@mic4ael mic4ael commented Oct 24, 2024

This MR aims to fix the a couple of issues in the argument parsing:

  1. InvertedSetting incorrectly defines its own __get__ and __set__ dunder methods.
  2. Boolean arguments are not properly initialized.
  3. daemonize is missing typeconv setting.

I have found all these issues (and a few more) while trying to deploy pyff on our infra at CERN.

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@mic4ael
Copy link
Author

mic4ael commented Oct 24, 2024

I would be really happy if you could apply the hacktoberfest-accepted label to this MR if you find it valuable and decide to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant