Fix invalid parsing of the bool arguments

src/pyff/constants.py

@@ -168,7 +168,7 @@ def short_spec(self):
 
     def long_spec(self):
         long_name = self.long_name
-        if hasattr(self, 'typeconv') and self.typeconv == as_bool:
+        if (hasattr(self, 'typeconv') and self.typeconv == as_bool) or isinstance(self, InvertedSetting):
             return '{}'.format(long_name)
         else:
             return '{}='.format(long_name)
@@ -201,10 +201,10 @@ def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
     def __get__(self, instance, owner):
-        return not self.setting.__get__()
+        return not self.setting.__get__(instance, owner)
 
     def __set__(self, instance, value):
-        self.setting.__set__(not value)
+        self.setting.__set__(instance, not value)
 
 
 class DummySetting(BaseSetting):
@@ -292,7 +292,7 @@ class Config(object):
 
     no_caching = N('no_caching', invert=caching_enabled, short='C', info="disable all caches")
 
-    daemonize = S("daemonize", default=True, cmdline=['pyffd'], info="run in background")
+    daemonize = S("daemonize", default=True, typeconv=as_bool, cmdline=['pyffd'], info="run in background")
 
     foreground = N('foreground', invert=daemonize, short='f', cmdline=['pyffd'], info="run in foreground")
 
@@ -546,14 +546,22 @@ def parse_options(program, docs):
                     config.aliases[a] = uri
             elif o in ('-m', '--module'):
                 config.modules.append(a)
+            elif o in ('-f', '--foreground'):
+                config.foreground = True
+            elif o in ('-C', '--no_caching'):
+                config.no_caching = True
             else:
                 o = o.lstrip('-')
                 s = config.find_setting(o)
                 if s is not None:
                     if s.deprecated:
                         print("WARNING: {} is deprecated. Setting this option has no effect!".format(o))
                     else:
-                        setattr(s, 'value', a)
+                        value = a
+                        if s.typeconv == as_bool:
+                            value = True
+
+                        setattr(s, 'value', value)
                 else:
                     raise ValueError("Unknown option {}".format(o))
 

src/pyff/test/test_parse_options.py

@@ -0,0 +1,28 @@
+import sys
+
+from unittest import TestCase
+from unittest.mock import patch
+
+from pyff.constants import parse_options, config
+
+
+class TestParseOptions(TestCase):
+
+    def test_bool_long_spec_setting(self):
+        test_args = ["pyffd", "--devel_memory_profile", "--foreground"]
+
+        with patch.object(sys, 'argv', test_args):
+            parse_options("pyffd", "Additional help.")
+
+        self.assertTrue(config.devel_memory_profile)
+        self.assertTrue(config.foreground)
+        self.assertFalse(config.daemonize)
+
+    def test_inverted_setting_short_spec(self):
+        test_args = ["pyffd", "-C"]
+
+        with patch.object(sys, 'argv', test_args):
+            parse_options("pyffd", "Additional help.")
+
+        self.assertTrue(config.no_caching)
+        self.assertFalse(config.caching_enabled)