New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igxTreeGrid Batch Update Implementation #2921

Closed

bazal4o opened this issue Nov 5, 2018 · 0 comments · Fixed by #3399

Assignees

Labels

grid: tree-grid version: 6.2.x ✅ status: resolved

Contributor

bazal4o commented Nov 5, 2018

Description

Implement igxTreeGrid Batch update

igniteui-angular version:
browser:

bazal4o added the grid: tree-grid label

bazal4o assigned wnvko and ViktorSlavov

bazal4o added 🛠️ status: in-development version: 6.2.x labels

ViktorSlavov mentioned this issue

IgxTreeGrid - Add row editing + transactions to tree grid #2908

Closed

2 tasks

bazal4o mentioned this issue

Updating the roadmap #2932

Merged

wnvko added a commit that referenced this issue


          refactor(tree-grid): remove unused methods and classes, #2921

eb192c3

wnvko mentioned this issue

igxTreeGrid batch update, #2921 #2954

Merged

wnvko added a commit that referenced this issue


          refactor(tree-grid): apply transaction in one iteration, #2921

bc96b52

By the help of transaction.path we are able to going trough all the changes
now and update the cloned data source without need of recursion.

wnvko added a commit that referenced this issue


          feat(tree-grid): update flat data transaction, #2921

8d4b355

_useInUndo flag added to IgxTreeGrid. When cascading delete rows in flat data
set this flag to false and push add it this way in transaction. This allow undo
to skip this transactions.

wnvko added a commit that referenced this issue


          feat(tree-grid): update flat data transaction, #2921

We are returning to startPending/endPending approach. This time on each
startPending we are pushing array of transactions to undo stack. If undo
gets called we remove the last array of transactions, splice the transactions
array, update the necessary states and push the array of transactions to redo
stack.

wnvko added a commit that referenced this issue


          refactor(tree-grid): remove unused methods and classes, #2921

8802b28

wnvko added a commit that referenced this issue


          refactor(tree-grid): apply transaction in one iteration, #2921

a4b9cfb

By the help of transaction.path we are able to going trough all the changes
now and update the cloned data source without need of recursion.

wnvko added a commit that referenced this issue


          feat(tree-grid): update flat data transaction, #2921

6716df6

_useInUndo flag added to IgxTreeGrid. When cascading delete rows in flat data
set this flag to false and push add it this way in transaction. This allow undo
to skip this transactions.

wnvko added a commit that referenced this issue


          feat(tree-grid): update flat data transaction, #2921

cd18034

We are returning to startPending/endPending approach. This time on each
startPending we are pushing array of transactions to undo stack. If undo
gets called we remove the last array of transactions, splice the transactions
array, update the necessary states and push the array of transactions to redo
stack.

wnvko added a commit that referenced this issue


          test(tree-grid): fix failing test in transactions, #2921

776b8a5

wnvko added a commit that referenced this issue


          feat(tree-grid): update states in hierarchical data, #2921

3a21f3d

If deleted transaction is added we are checking all current states. If any of
them is for row which is child of the deleted row we are updating its state.

wnvko added a commit that referenced this issue


          feat(tree-grid): hierarchical transaction are in stable state now, #2921

29b3bee



ADD, UPDATE, DELETE, UNDO, REDO and COMMIT should working now for both
flat and hierarchical data source

wnvko added a commit that referenced this issue


          refactor(tree-grid): remove unused methods and classes, #2921

ed848b9

wnvko added a commit that referenced this issue


          refactor(tree-grid): apply transaction in one iteration, #2921

600a505

By the help of transaction.path we are able to going trough all the changes
now and update the cloned data source without need of recursion.

wnvko added a commit that referenced this issue


          feat(tree-grid): update flat data transaction, #2921

35ba3f4

_useInUndo flag added to IgxTreeGrid. When cascading delete rows in flat data
set this flag to false and push add it this way in transaction. This allow undo
to skip this transactions.

wnvko added a commit that referenced this issue


          feat(tree-grid): update flat data transaction, #2921

208ef45

We are returning to startPending/endPending approach. This time on each
startPending we are pushing array of transactions to undo stack. If undo
gets called we remove the last array of transactions, splice the transactions
array, update the necessary states and push the array of transactions to redo
stack.

wnvko added a commit that referenced this issue


          refactor(tree-grid): apply transaction in one iteration, #2921

08c1e1a

By the help of transaction.path we are able to going trough all the changes
now and update the cloned data source without need of recursion.

wnvko added a commit that referenced this issue


          feat(tree-grid): update flat data transaction, #2921

0e89cf3

_useInUndo flag added to IgxTreeGrid. When cascading delete rows in flat data
set this flag to false and push add it this way in transaction. This allow undo
to skip this transactions.

wnvko added a commit that referenced this issue


          feat(tree-grid): update flat data transaction, #2921

824f692

We are returning to startPending/endPending approach. This time on each
startPending we are pushing array of transactions to undo stack. If undo
gets called we remove the last array of transactions, splice the transactions
array, update the necessary states and push the array of transactions to redo
stack.

wnvko added a commit that referenced this issue


          test(tree-grid): fix failing test in transactions, #2921

0a8f266

wnvko added a commit that referenced this issue


          feat(tree-grid): update states in hierarchical data, #2921

e7df41d

If deleted transaction is added we are checking all current states. If any of
them is for row which is child of the deleted row we are updating its state.

wnvko added a commit that referenced this issue


          feat(tree-grid): hierarchical transaction are in stable state now, #2921

73cc267



ADD, UPDATE, DELETE, UNDO, REDO and COMMIT should working now for both
flat and hierarchical data source

wnvko added a commit that referenced this issue


          refactor(tree-grid): remove unused methods and classes, #2921

8d1f8ae

wnvko pushed a commit that referenced this issue


          test(IgxTreeGrid): Adding empty ChildDataKey test. #2921

0bd0eed

wnvko added a commit that referenced this issue


          fix(tree-grid): edit added row with rowEdit=true, #2921

0f4542a

wnvko pushed a commit that referenced this issue


          chore(IgxTreeGrid): Remove test, add Batch Editing describe. #2921

da2e58e

wnvko added a commit that referenced this issue


          fix(tree-grid): add row with transactions to empty grid, #2921

60af885

wnvko added a commit that referenced this issue


          test(tree-grid): add empty grid test scenarios, #2921

wnvko added a commit that referenced this issue


          test(tree-grid): add more test for hierarchical transaction, #2921

7c0c166

wnvko pushed a commit that referenced this issue


          test(tree-grid): test add parent node to a Hierarchical DS tree grid, #…

8445cab

…2921

wnvko pushed a commit that referenced this issue


          test(IgxTreeGrid): Adding rows to empty data grid tests. #2921

0fc7d4f

wnvko added a commit that referenced this issue


          test(tree-grid): merge transactions tests add, #2921

dc360a4

wnvko added a commit that referenced this issue


          test(igxTreeGrid): whatever I put here Damian will squash it, #2921

c926efd

wnvko added a commit that referenced this issue


          refactor(igxTreeGrid): remove path splice in merge, #2921

b7d28dd

Also fix incorrect test.

wnvko added a commit that referenced this issue


          refactor(igxTreeGrid): update mergeHierarchicalTransaction, #2921

5fda341

wnvko added a commit that referenced this issue


          chore(igxTreeGrid): remove commented rows, #2921

90add5c

wnvko added a commit that referenced this issue


          chore(igxTreGeid): update CHANGELOG.md, #2921

867588c

wnvko added a commit that referenced this issue


          refactor(igxTreeGrid): make deleteRowById protected and refactor it, #…

8422d08

…2921

Refactor and deleteRowFromData - it should not use data with added rows.
Switch primaryKey and childDataKey parameters positions in commit function.

wnvko added a commit that referenced this issue


          chore(igxTreeGrid): fix after merge errors, #2921

98d2a57

wnvko added a commit that referenced this issue


          refactor(igxTreeGrid): switch array.map to for-of, #2921

ae0683b

wnvko added a commit that referenced this issue


          refactor(igxTreeGrid): switch array.map and for loops with for-of, #2921

39fa460

wnvko added a commit that referenced this issue


          chore(igxTreeGrid): switch back from ChromeHeadless to Chrome, #2921

60ab88d

bazal4o closed this as completed in #2954

bazal4o added a commit that referenced this issue


          Merge pull request #2954 from IgniteUI/mvenkov/tree-grid-batch-update

cb75b44

igxTreeGrid batch update, #2921

wnvko added a commit that referenced this issue


          fix(igxTransaction): call onStateUpdate in endPending, #2921

8e9eacd

wnvko added a commit that referenced this issue


          test(igxTransaction): add tests for onStateUpdate event, #2921

6de7ce2

wnvko added a commit that referenced this issue


          test(igxTransaction): error on calling getAggregatedChanges(false), #…

5ed94d2

…2921

wnvko added a commit that referenced this issue


          fix(igxTransaction): should correctly call getAggregatedChanges(false),

dc9241d

#2921

wnvko mentioned this issue

Treegrid batch update fixes, #2921 #3399

Merged

3 tasks

wnvko added a commit that referenced this issue


          chore(igxTransaction): remove fdescribe from tests, #2921

090840d

bazal4o added a commit that referenced this issue


          Merge pull request #3399 from IgniteUI/mvenkov/treegrid-batch-update-…

eceaa09

…fixes

Treegrid batch update fixes, #2921

wnvko added ✅ status: resolved and removed 🛠️ status: in-development labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment