igxTreeGrid batch update, #2921 #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wnvko
added
🛠️ status: in-development
Lipata
previously approved these changes
Nov 7, 2018
Lipata
previously approved these changes
Nov 13, 2018
wnvko
added
❌ status: awaiting-test
This comment has been minimized.
This comment has been minimized.
By the help of transaction.path we are able to going trough all the changes now and update the cloned data source without need of recursion.
_useInUndo flag added to IgxTreeGrid. When cascading delete rows in flat data set this flag to false and push add it this way in transaction. This allow undo to skip this transactions.
We are returning to startPending/endPending approach. This time on each startPending we are pushing array of transactions to undo stack. If undo gets called we remove the last array of transactions, splice the transactions array, update the necessary states and push the array of transactions to redo stack.
By the help of transaction.path we are able to going trough all the changes now and update the cloned data source without need of recursion.
_useInUndo flag added to IgxTreeGrid. When cascading delete rows in flat data set this flag to false and push add it this way in transaction. This allow undo to skip this transactions.
damyanpetev
reviewed
Dec 6, 2018
projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts
Outdated
Show resolved
Hide resolved
damyanpetev
reviewed
Dec 6, 2018
projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts
Outdated
Show resolved
Hide resolved
damyanpetev
reviewed
Dec 6, 2018
projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts
Outdated
Show resolved
Hide resolved
damyanpetev
reviewed
Dec 6, 2018
projects/igniteui-angular/src/lib/services/transaction/igx-hierarchical-transaction.ts
Outdated
Show resolved
Hide resolved
…2921 Refactor and deleteRowFromData - it should not use data with added rows. Switch primaryKey and childDataKey parameters positions in commit function.
…e-grid-batch-update # Conflicts: # CHANGELOG.md # src/app/app.component.ts # src/app/tree-grid-flat-data/tree-grid-flat-data.sample.html # src/app/tree-grid-flat-data/tree-grid-flat-data.sample.ts # src/app/tree-grid/tree-grid.sample.html
damyanpetev
reviewed
Dec 7, 2018
projects/igniteui-angular/src/lib/services/transaction/igx-transaction.ts
Outdated
Show resolved
Hide resolved
damyanpetev
previously approved these changes
Dec 7, 2018
dafo
added
💥 status: in-test
…e-grid-batch-update # Conflicts: # projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-api.service.ts # projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts
damyanpetev
approved these changes
Dec 7, 2018
dafo
added
✅ status: verified
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2921