Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When scroll with the mouse wheel the value in datePicker editor for edited cell is empty #2958

Closed
nrobakova opened this issue Nov 7, 2018 · 2 comments · Fixed by #3307
Closed

When scroll with the mouse wheel the value in datePicker editor for edited cell is empty #2958

nrobakova opened this issue Nov 7, 2018 · 2 comments · Fixed by #3307
Assignees
@dkamburov @mpavlinov
Labels
🐛 bug Any issue that describes a bug 📉 regression 🧨 severity: medium grid: cell-editing grid: general version: 6.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@nrobakova
Copy link
Contributor

Description

When scroll with the mouse wheel the value in datePicker editor for edited cell is empty

  • igniteui-angular version: 6.2.x
  • browser: N/A

Steps to reproduce

  1. Open dev sample gridCellEditing
  2. Open a cell in column OrderDate in edit mode
  3. Scroll with the mouse wheel

This issue is related to the issue #2535

Result

Value in the datePicker is empty

Expected result

Value should be correct

Attachments

Attach a sample if available, and screenshots, if applicable.
image
@zdrawku zdrawku assigned gedinakova and unassigned ddincheva Nov 8, 2018
@tachojelev tachojelev added 🛠️ status: in-development Issues and PRs with active development on them 📉 regression labels Nov 8, 2018
@tachojelev
Copy link
Contributor

The issue is not reproduced in 6.1.x.

@tachojelev tachojelev added 🆕 status: new and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 9, 2018
@tachojelev
Copy link
Contributor

A possible fix for this issue would be invoking the detectChanges() method at the end of the onScroll() method of the IgxGridForOfDirective, however this should not be necessary since the IgxGridBaseComponent's verticalScrollHandler invokes the onScroll method and the detectChanges method successively.
This is why since the issue is reproduced with the scroll wheel, we may want to take a look at the IgxScrollInertiaDirective to resolve this issue instead of using detectChanges.

@tachojelev tachojelev assigned mpavlinov and unassigned tachojelev and gedinakova Nov 14, 2018
@dkamburov dkamburov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Nov 28, 2018
dkamburov added a commit that referenced this issue Nov 28, 2018
@dkamburov
fix(igxCell): Use value instead of ngModel (#2958)
2208574
dkamburov added a commit that referenced this issue Nov 28, 2018
@dkamburov
fix(igxCell): Add change and onSelection event to reflect value chang…
8b4b1c7 
…es (#2958)
dkamburov added a commit that referenced this issue Nov 28, 2018
@dkamburov
fix(igxCell): Add change and onSelection for tree-cell too (#2958)
e35071c
dkamburov added a commit that referenced this issue Nov 28, 2018
@dkamburov
fix(igxCell): Use value instead of ngModel (#2958)
d15482c
This was referenced Nov 29, 2018
Merged
Merged
dkamburov added a commit that referenced this issue Nov 29, 2018
@dkamburov
fix(igxCell): Expose and use getter and setter for editValue (#2958)
adf8335
dkamburov added a commit that referenced this issue Nov 29, 2018
@dkamburov
fix(igxCell): Expose and use getter and setter for editValue (#2958)
bd1caad
@dkamburov dkamburov added the 💥 status: in-test PRs currently being tested label Nov 29, 2018
@dkamburov dkamburov added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them 💥 status: in-test PRs currently being tested labels Nov 29, 2018
@mpavlinov mpavlinov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 30, 2018
dkamburov added a commit that referenced this issue Dec 4, 2018
@dkamburov
fix(igxCell): Use value instead of ngModel (#2958)
a7ef9f0
dkamburov added a commit that referenced this issue Dec 4, 2018
@dkamburov
fix(igxCell): Expose and use getter and setter for editValue (#2958)
124660a
@dkamburov dkamburov mentioned this issue Dec 4, 2018
Merged
3 tasks
rkaraivanov pushed a commit that referenced this issue Dec 6, 2018
@dkamburov @rkaraivanov
Use value instead of ngModel to update editValue for checkbox and cal…
daaedc9 
…endar in igxCell (#3224)

* fix(igxCell): Use value instead of ngModel (#2958)

* fix(igxCell): Add change and onSelection event to reflect value changes (#2958)

*  fix(igxCell): Add change and onSelection for tree-cell too (#2958)

* fix(igxCell): Expose and use getter and setter for editValue (#2958)

* chore(igxCell): Fix failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkamburov dkamburov

@mpavlinov mpavlinov

Labels
🐛 bug Any issue that describes a bug 📉 regression 🧨 severity: medium grid: cell-editing grid: general version: 6.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
6 participants
@dkamburov @mpavlinov @nrobakova @tachojelev @gedinakova @ddincheva