Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use value instead of ngModel to update editValue for checkbox and calendar in igxCell #3224

Merged
merged 9 commits into from
Dec 6, 2018
Merged

Use value instead of ngModel to update editValue for checkbox and calendar in igxCell #3224

merged 9 commits into from
Dec 6, 2018

Conversation

dkamburov
Copy link
Contributor

@dkamburov dkamburov commented Nov 29, 2018 •
edited
Loading

Closes #2958

Additional information (check all that apply):

  • Bug fix
  • Documentation

Checklist:

  • All relevant tags have been applied to this PR

@dkamburov dkamburov changed the title Dkamburov/fix 2958 6.2.x Use value instead of ngModel to update editValue for checkbox and calendar in igxCell Nov 29, 2018
MayaKirova
MayaKirova previously approved these changes Nov 29, 2018
View reviewed changes
@VMihalkov VMihalkov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Dec 6, 2018
@kdinev kdinev removed the 🐛 bug Any issue that describes a bug label Dec 6, 2018
@rkaraivanov rkaraivanov merged commit daaedc9 into 6.2.x Dec 6, 2018
@rkaraivanov rkaraivanov deleted the dkamburov/fix-2958-6.2.x branch December 6, 2018 16:17
@tachojelev tachojelev removed their request for review December 20, 2018 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@MayaKirova MayaKirova MayaKirova left review comments

@ddincheva ddincheva Awaiting requested review from ddincheva

@mpavlinov mpavlinov Awaiting requested review from mpavlinov

Assignees

@VMihalkov VMihalkov

Labels
🧨 severity: medium grid: cell-editing version: 6.2.x virtualization ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dkamburov @MayaKirova @rkaraivanov @kdinev @VMihalkov