Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igx-grid - groupsRecords is not updated yet at the time of onGroupingDone event. #2967

Closed
tkiryu opened this issue Nov 8, 2018 · 4 comments
Closed

igx-grid - groupsRecords is not updated yet at the time of onGroupingDone event. #2967

tkiryu opened this issue Nov 8, 2018 · 4 comments
Assignees
@ChronosSF
Labels
🐛 bug Any issue that describes a bug 📉 regression grid: groupby status: cannot-reproduce version: 6.2.x version: 13.2.x

Comments

@tkiryu
Copy link

tkiryu commented Nov 8, 2018

Description

groupsRecords is not updated yet at the time of onGroupingDone event.

  • igniteui-angular version: 6.2.0
  • browser: N/A

Steps to reproduce

  1. Go to https://stackblitz.com/edit/igx-grid-ongroupingdone-620
  2. Open the console.
  3. Drag and drop a column to the group area.

Result

Although onGroupingDone event is emitted, groupsRecords is not updated yet. We get the previous value.

Expected result

Until 6.1.8, this value had been updated as expected.
https://stackblitz.com/edit/igx-grid-ongroupingdone-618
@PavlovVasil PavlovVasil added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Nov 12, 2018
PavlovVasil added a commit that referenced this issue Nov 13, 2018
@PavlovVasil
fix(groupBy): update the state before raising onGroupingDone event #2967
60e1c40
PavlovVasil added a commit that referenced this issue Nov 13, 2018
@PavlovVasil
fix(groupBy): update the state before raising onGroupingDone event #2967
b366ef0
@PavlovVasil PavlovVasil mentioned this issue Nov 13, 2018
Merged
@PavlovVasil PavlovVasil added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 13, 2018
PavlovVasil added a commit that referenced this issue Nov 14, 2018
@PavlovVasil
fix(groupBy): calling detectChanges instead of ngDoCheck #2967
56a2793
kdinev pushed a commit that referenced this issue Nov 15, 2018
@PavlovVasil @kdinev
The grid should update groupsRecords before raising the onGroupingDon…
ffd1e3c 
…e event - 6.2.x, #2967 (#3009)

* fix(groupBy): update the state before raising onGroupingDone event #2967

* fix(groupBy): calling detectChanges instead of ngDoCheck  #2967
kdinev added a commit that referenced this issue Nov 19, 2018
@kdinev
Merging 6.2.x into master (#3019)
ddf7802 
* feat(grid, chip): add display density DI token to igxGrid and igxChip

* Resolving confilcts related to the new structure(grids ->grid)

* Fixing styling issue

* Adding event arguments for DenistyChanged

* Renaming IDisplayDenisty to IDisplayDenistyOptions and setting IDensityChangedEventArgs type to be DisplayDenisty

* Trigger onDensityChanged only for components that do not have displayDenisty explicitly set when the global denisty is changed

* Adding displayDenisty DI in tree grid constructor

* Group by chips are now affected from the global display denisty option

* fix(igxGrid): dirty check only checks if value exists, #2940

* fix(igx-grid): Open date-picker only if condition is not unary, #2937

* Summaries display denisty classes are now correctly applied

* Removing dsiplayDenisty property since it is not needed any more

* fix(igx-grid): Clear filter when value is cleared from input, #2945

* test(treeGrid): Update treeGrid Keyboard navigation tests #2953

* Improve keyboard navigation in filtering (#2964)

* fix(igx-grid): Improve keyboard navigation in filtering, #2951

* fix(igx-grid): Get scroll from first row, when there is one, #2951

* chore(igx-grid): Refactor code, #2951

* chore(igx-grid): Add cases for groupbyrow and pinned columns, #2951

* chore(igx-grid): Fix lint errors, #2951

* feat(igx-grid): Close filter row on Esc, #2979

* test(igx-grid): Add test, #2979

* chore(*): Merging master into 6.2.x

* Sorting strategy merge 6.2.x (#2998)

* feat(grid sorting): Merging the new sorting strategy into 6.2.x #2734

* chore(*): Adding missing imports to grid-selection tests

* chore(*): More test import fixes

* chore(*): Applying the groupby changes with the new sorting strategy

* chore(*): Resolving the column moving test issue

* chore(*): This should be it with the test fixes

* chore(*): Removing the fdescribe

* Add igxDropDown maxHeight input (#3005)

* feat(igxDropDown): introduce itemsMaxHeight property #3001

* test(igxDropDown): test for max height #3001

* docs(igxDropDown): changelog update #3001

* test(igxCombo): adjust tests according to new dropdown structure #3001

* test(igxDropDown): add more tests #3001

* fix(grid): MultiColumn headers should not be grouped #2944 (#2970)

* chore(*): Fixing the demos

* feat(themes): add theme schemas (#3006)

* refactor(themes): introduce presets as basis for component themes

* refactor(themes): create schemas for more comopnents

* refactor(themes): create schemas for more comopnents

* refactor(themes): introduce presets as basis for component themes

* refactor(themes): create schemas for more comopnents

* refactor(themes): create schemas for more comopnents

* refactor(themes): introduce presets as basis for component themes

* refactor(themes): create schemas for more comopnents

* refactor(themes): create schemas for more comopnents

* refactor(themes): introduce presets as basis for component themes

* refactor(themes): create schemas for more comopnents

* refactor(themes): add schemas for the remaining component themes

* refactor(themes): change presets to schemas

* fix(themes): value resolver always returns  string

* refactor(themes): remove all $default-theme references

* docs(themes): add docs for newly introduced functions

* refactor(demos): update demos theme

* build(themes): fix css theme not building

* refactor(themes): optimize palette generation

* refactor(combo) - navigation (#2999)

* refactor(combo): refactor combo navigation, WIP

* refactor(combo): refactor combo navigation

* refactor(combo): add comments, trim, remove console.log

* refactor(combo): add comments, trim, remove console.log

* chore(combo): adjust failing tests

* refactor(igxCombo): remove focusItem, use super.navigateItem instead

* refactor(igxCombo): add navigate virtual

* refactor(igxCombo): add focus add button + findFocusableIndex methods

* refactor(igxCombo): adjust incorrect `navigateItem` calls

* refactor(igxCombo): first header is not loaded and focus search - scroll, #2999

* The grid should update groupsRecords before raising the onGroupingDone event - 6.2.x,  #2967 (#3009)

* fix(groupBy): update the state before raising onGroupingDone event #2967

* fix(groupBy): calling detectChanges instead of ngDoCheck  #2967
kdinev added a commit that referenced this issue Nov 20, 2018
@kdinev
Merging 6.2.x into master (#3038)
856a0d3 
* feat(grid, chip): add display density DI token to igxGrid and igxChip

* Resolving confilcts related to the new structure(grids ->grid)

* Fixing styling issue

* Adding event arguments for DenistyChanged

* Renaming IDisplayDenisty to IDisplayDenistyOptions and setting IDensityChangedEventArgs type to be DisplayDenisty

* Trigger onDensityChanged only for components that do not have displayDenisty explicitly set when the global denisty is changed

* Adding displayDenisty DI in tree grid constructor

* Group by chips are now affected from the global display denisty option

* fix(igxGrid): dirty check only checks if value exists, #2940

* fix(igx-grid): Open date-picker only if condition is not unary, #2937

* Summaries display denisty classes are now correctly applied

* Removing dsiplayDenisty property since it is not needed any more

* fix(igx-grid): Clear filter when value is cleared from input, #2945

* test(treeGrid): Update treeGrid Keyboard navigation tests #2953

* Improve keyboard navigation in filtering (#2964)

* fix(igx-grid): Improve keyboard navigation in filtering, #2951

* fix(igx-grid): Get scroll from first row, when there is one, #2951

* chore(igx-grid): Refactor code, #2951

* chore(igx-grid): Add cases for groupbyrow and pinned columns, #2951

* chore(igx-grid): Fix lint errors, #2951

* fix(grid): update method _updateVScrollOffset to calculate top #2957

* fix(grid): update lint #2957

* feat(igx-grid): Close filter row on Esc, #2979

* fix(grid): Recalculate start index on _applyChanges #2957

* fix(grid): Update lint #2957

* test(igx-grid): Add test, #2979

* fix(IgxTreeGrid): refocus row when expand/collapse tree row #2935

* fix(IgxGrid): shound not toggle expand on arrowLeft when row is expanded #2950

* chore(*): Merging master into 6.2.x

* Sorting strategy merge 6.2.x (#2998)

* feat(grid sorting): Merging the new sorting strategy into 6.2.x #2734

* chore(*): Adding missing imports to grid-selection tests

* chore(*): More test import fixes

* chore(*): Applying the groupby changes with the new sorting strategy

* chore(*): Resolving the column moving test issue

* chore(*): This should be it with the test fixes

* chore(*): Removing the fdescribe

* Add igxDropDown maxHeight input (#3005)

* feat(igxDropDown): introduce itemsMaxHeight property #3001

* test(igxDropDown): test for max height #3001

* docs(igxDropDown): changelog update #3001

* test(igxCombo): adjust tests according to new dropdown structure #3001

* test(igxDropDown): add more tests #3001

* fix(grid): MultiColumn headers should not be grouped #2944 (#2970)

* chore(*): Fixing the demos

* feat(themes): add theme schemas (#3006)

* refactor(themes): introduce presets as basis for component themes

* refactor(themes): create schemas for more comopnents

* refactor(themes): create schemas for more comopnents

* refactor(themes): introduce presets as basis for component themes

* refactor(themes): create schemas for more comopnents

* refactor(themes): create schemas for more comopnents

* refactor(themes): introduce presets as basis for component themes

* refactor(themes): create schemas for more comopnents

* refactor(themes): create schemas for more comopnents

* refactor(themes): introduce presets as basis for component themes

* refactor(themes): create schemas for more comopnents

* refactor(themes): add schemas for the remaining component themes

* refactor(themes): change presets to schemas

* fix(themes): value resolver always returns  string

* refactor(themes): remove all $default-theme references

* docs(themes): add docs for newly introduced functions

* refactor(demos): update demos theme

* build(themes): fix css theme not building

* refactor(themes): optimize palette generation

* refactor(combo) - navigation (#2999)

* refactor(combo): refactor combo navigation, WIP

* refactor(combo): refactor combo navigation

* refactor(combo): add comments, trim, remove console.log

* refactor(combo): add comments, trim, remove console.log

* chore(combo): adjust failing tests

* refactor(igxCombo): remove focusItem, use super.navigateItem instead

* refactor(igxCombo): add navigate virtual

* refactor(igxCombo): add focus add button + findFocusableIndex methods

* refactor(igxCombo): adjust incorrect `navigateItem` calls

* refactor(igxCombo): first header is not loaded and focus search - scroll, #2999

* The grid should update groupsRecords before raising the onGroupingDone event - 6.2.x,  #2967 (#3009)

* fix(groupBy): update the state before raising onGroupingDone event #2967

* fix(groupBy): calling detectChanges instead of ngDoCheck  #2967

* fix(grid): #2507 prevent scrolling on arrow keys (#2989)

* fix(grid): #2507 prevent scrolling on arrow keys

* fix(grid): #2507 prevent scrolling for default columns only

* Feat - Combo - Add DisplayDensity Input to Combo and Drop Down (#3007)

* feat(igxCombo): add display density to combo component, refactor template,#2410

* feat(igxCombo): add hidden to binding, add display: block, fix tests, #2410

* feat(igxCombo): move display styling in styles, remove hostbinding, #2410

* chore(*): Updating the PR template (#3036)

* chore(*): Updating the PR template

* chore(*): Addressing Stamen's comment

* fix(grid): removing checks which prevent scrolling #2971 (#3022)
@SkylerLutz
Copy link

I'm seeing this issue in 13.1.12 and 13.2.24. Can this please be reopened?

@SkylerLutz
Copy link

@kdinev
I'm seeing this issue in 13.1.12 and 13.2.24. Can this please be reopened? Thank you

@kdinev kdinev reopened this Apr 7, 2023
@kdinev kdinev assigned ChronosSF and unassigned mpavlinov and PavlovVasil Apr 7, 2023
@kdinev
Copy link
Member

kdinev commented Apr 7, 2023

@SkylerLutz @ChronosSF I'm reopening the issue. Someone will take a look at whether and why it has been regressed,

@ChronosSF ChronosSF removed the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Apr 7, 2023
@ChronosSF
Copy link
Member

@SkylerLutz , I tried this here: https://stackblitz.com/edit/angular-hv2b6k-wnnhgk using the latest supported version 15.1 and it works fine. I am console logging what grid.groupsRecords returns in the handler of groupingDone and it looks correctly updated.

Have in mind that groupsRecords returns a tree-like structure where the initial array contains only top-level group records. You need to drilldown to get child groups, e.g. grid.groupsRecords[0].groups returns the second level children for the first group record, grid.groupsRecords[0].groups[0].groups would be the third level children of the first parent and the first of its children, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChronosSF ChronosSF

Labels
🐛 bug Any issue that describes a bug 📉 regression grid: groupby status: cannot-reproduce version: 6.2.x version: 13.2.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kdinev @ChronosSF @SkylerLutz @mpavlinov @tkiryu @PavlovVasil @SlavUI