fix(grid): #2507 prevent scrolling on arrow keys #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddincheva
requested changes
Nov 12, 2018
There was a problem hiding this comment.
This fix brakes the default behavior of arrow keys, so when you define a custom edit template in column which is from data type boolean or date you can not navigate inside the input for example. So may be it is good idea, this fix to be applied only for our default edit templates.
DiyanDimitrov
approved these changes
Nov 14, 2018
mtsvyatkova
added
💥 status: in-test
ddincheva
approved these changes
Nov 19, 2018
kdinev
added a commit
that referenced
this pull request
Nov 20, 2018
* feat(grid, chip): add display density DI token to igxGrid and igxChip * Resolving confilcts related to the new structure(grids ->grid) * Fixing styling issue * Adding event arguments for DenistyChanged * Renaming IDisplayDenisty to IDisplayDenistyOptions and setting IDensityChangedEventArgs type to be DisplayDenisty * Trigger onDensityChanged only for components that do not have displayDenisty explicitly set when the global denisty is changed * Adding displayDenisty DI in tree grid constructor * Group by chips are now affected from the global display denisty option * fix(igxGrid): dirty check only checks if value exists, #2940 * fix(igx-grid): Open date-picker only if condition is not unary, #2937 * Summaries display denisty classes are now correctly applied * Removing dsiplayDenisty property since it is not needed any more * fix(igx-grid): Clear filter when value is cleared from input, #2945 * test(treeGrid): Update treeGrid Keyboard navigation tests #2953 * Improve keyboard navigation in filtering (#2964) * fix(igx-grid): Improve keyboard navigation in filtering, #2951 * fix(igx-grid): Get scroll from first row, when there is one, #2951 * chore(igx-grid): Refactor code, #2951 * chore(igx-grid): Add cases for groupbyrow and pinned columns, #2951 * chore(igx-grid): Fix lint errors, #2951 * fix(grid): update method _updateVScrollOffset to calculate top #2957 * fix(grid): update lint #2957 * feat(igx-grid): Close filter row on Esc, #2979 * fix(grid): Recalculate start index on _applyChanges #2957 * fix(grid): Update lint #2957 * test(igx-grid): Add test, #2979 * fix(IgxTreeGrid): refocus row when expand/collapse tree row #2935 * fix(IgxGrid): shound not toggle expand on arrowLeft when row is expanded #2950 * chore(*): Merging master into 6.2.x * Sorting strategy merge 6.2.x (#2998) * feat(grid sorting): Merging the new sorting strategy into 6.2.x #2734 * chore(*): Adding missing imports to grid-selection tests * chore(*): More test import fixes * chore(*): Applying the groupby changes with the new sorting strategy * chore(*): Resolving the column moving test issue * chore(*): This should be it with the test fixes * chore(*): Removing the fdescribe * Add igxDropDown maxHeight input (#3005) * feat(igxDropDown): introduce itemsMaxHeight property #3001 * test(igxDropDown): test for max height #3001 * docs(igxDropDown): changelog update #3001 * test(igxCombo): adjust tests according to new dropdown structure #3001 * test(igxDropDown): add more tests #3001 * fix(grid): MultiColumn headers should not be grouped #2944 (#2970) * chore(*): Fixing the demos * feat(themes): add theme schemas (#3006) * refactor(themes): introduce presets as basis for component themes * refactor(themes): create schemas for more comopnents * refactor(themes): create schemas for more comopnents * refactor(themes): introduce presets as basis for component themes * refactor(themes): create schemas for more comopnents * refactor(themes): create schemas for more comopnents * refactor(themes): introduce presets as basis for component themes * refactor(themes): create schemas for more comopnents * refactor(themes): create schemas for more comopnents * refactor(themes): introduce presets as basis for component themes * refactor(themes): create schemas for more comopnents * refactor(themes): add schemas for the remaining component themes * refactor(themes): change presets to schemas * fix(themes): value resolver always returns string * refactor(themes): remove all $default-theme references * docs(themes): add docs for newly introduced functions * refactor(demos): update demos theme * build(themes): fix css theme not building * refactor(themes): optimize palette generation * refactor(combo) - navigation (#2999) * refactor(combo): refactor combo navigation, WIP * refactor(combo): refactor combo navigation * refactor(combo): add comments, trim, remove console.log * refactor(combo): add comments, trim, remove console.log * chore(combo): adjust failing tests * refactor(igxCombo): remove focusItem, use super.navigateItem instead * refactor(igxCombo): add navigate virtual * refactor(igxCombo): add focus add button + findFocusableIndex methods * refactor(igxCombo): adjust incorrect `navigateItem` calls * refactor(igxCombo): first header is not loaded and focus search - scroll, #2999 * The grid should update groupsRecords before raising the onGroupingDone event - 6.2.x, #2967 (#3009) * fix(groupBy): update the state before raising onGroupingDone event #2967 * fix(groupBy): calling detectChanges instead of ngDoCheck #2967 * fix(grid): #2507 prevent scrolling on arrow keys (#2989) * fix(grid): #2507 prevent scrolling on arrow keys * fix(grid): #2507 prevent scrolling for default columns only * Feat - Combo - Add DisplayDensity Input to Combo and Drop Down (#3007) * feat(igxCombo): add display density to combo component, refactor template,#2410 * feat(igxCombo): add hidden to binding, add display: block, fix tests, #2410 * feat(igxCombo): move display styling in styles, remove hostbinding, #2410 * chore(*): Updating the PR template (#3036) * chore(*): Updating the PR template * chore(*): Addressing Stamen's comment * fix(grid): removing checks which prevent scrolling #2971 (#3022)
katherinedragieva
added a commit
that referenced
this pull request
Apr 18, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2507
Added event.preventDefault for date and boolean cells(columns) in editMode, to stop the page scrolling with arrow up/down.
As Desi suggested, the fixed is applied only for default grid columns.
Note: This behavior cannot be simulated with test framework, so there isn't any test related