Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igxToolbar should have the option to add custom template #2983

Closed
jdk339 opened this issue Nov 9, 2018 · 5 comments
Closed

igxToolbar should have the option to add custom template #2983

jdk339 opened this issue Nov 9, 2018 · 5 comments
Assignees
Labels
grid: toolbar 🧰 feature-request version: 6.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@jdk339
Copy link

jdk339 commented Nov 9, 2018

Feature Request

It would awesome if the Grid (igx-grid) could have additional toolbar features, such as clearing the current filters, clearing sorting, and toggling the summary. Currently, it's no trouble to include such functionality elsewhere, but it would make sense to be in the Grid toolbar along with the other features.

Here is how I currently do it outside the grid:

<div>
  <button igxButton="flat" igxRipple igxRippleCentered="true" (click)="grid.clearFilter()">
    <igx-icon fontSet="material" name="clear"></igx-icon>
    CLEAR FILTERS
  </button>
  <button class="marg-l-10" igxButton="flat" igxRipple igxRippleCentered="true" (click)="grid.clearSort()">
    <igx-icon fontSet="material" name="clear"></igx-icon>
    CLEAR SORTING
  </button>
  <igx-switch class="marg-l-10" [checked]="summariesEnabled" (change)="toggleSummaries($event)">
    TOGGLE SUMMARY
  </igx-switch>
</div>

igx grid toolbar idea

@zdrawku
Copy link
Contributor

zdrawku commented Nov 12, 2018

Thank you for the recommendation @jdk339!

@SlavUI
Copy link
Contributor

SlavUI commented Nov 13, 2018

@kdinev and @StefanIvanov Guys what do you think ? I think this is a really good idea :)

@kdinev
Copy link
Member

kdinev commented Nov 13, 2018

The issue is similar to #2887 The toolbar should expose the empty outlet for templating by the user. There will be different use-cases for actions developers want to put in the toolbar, so instead of trying to exhaust them all with configuration, we should just expose a template.

@SlavUI Can we prioritize this for the next sprint?

@StefanIvanov
Copy link
Contributor

I agree 100% with @kdinev and that would allow @jdk339 to use the snippet and create such a template but spare his time regarding styling as the toolbar will define that for him.

rmkrmk pushed a commit that referenced this issue Nov 23, 2018
@SlavUI SlavUI changed the title Add more clearing buttons to Grid toolbar igxToolbar should have the option to add custom template Dec 5, 2018
@kdinev
Copy link
Member

kdinev commented Dec 6, 2018

@jdk339 This update will appear with the next tag - 7.1.0, as well as in patches 6.2.4 and 7.0.3

@kdinev kdinev closed this as completed Dec 6, 2018
@rmkrmk rmkrmk added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: toolbar 🧰 feature-request version: 6.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

No branches or pull requests

7 participants