Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom content outlet for IgxGridToolbar - 6.2.x #3107

Merged
merged 30 commits into from
Dec 6, 2018
Merged

Add custom content outlet for IgxGridToolbar - 6.2.x #3107

merged 30 commits into from
Dec 6, 2018

Conversation

rmkrmk
Copy link
Contributor

@rmkrmk rmkrmk commented Nov 22, 2018 •
edited
Loading

#2983

Additional information (check all that apply):

  • New functionality

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@rmkrmk rmkrmk added the ❌ status: awaiting-test PRs awaiting manual verification label Nov 22, 2018
@rmkrmk rmkrmk changed the title Rkolev/toolbar template 6.2.x Add custom content outlet for IgxGridToolbar - 6.2.x Nov 22, 2018
simeonoff
simeonoff previously approved these changes Nov 22, 2018
View reviewed changes
rkaraivanov
rkaraivanov previously approved these changes Nov 26, 2018
View reviewed changes
simeonoff
simeonoff previously approved these changes Nov 27, 2018
View reviewed changes
@rmkrmk rmkrmk dismissed stale reviews from simeonoff and rkaraivanov via 1a2ad82 November 27, 2018 11:18
simeonoff
simeonoff previously approved these changes Nov 27, 2018
View reviewed changes
@tachojelev tachojelev self-assigned this Nov 28, 2018
@tachojelev tachojelev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 28, 2018
@tachojelev
Copy link
Contributor

Issue:

@rmkrmk Currently if we provide a custom template for the toolbar content without having any of the default buttons and title enabled (but showToolbar is true), the toolbar is not visible.

@tachojelev tachojelev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Dec 3, 2018
kdinev
kdinev previously approved these changes Dec 3, 2018
View reviewed changes
@kdinev kdinev merged commit ea6159d into 6.2.x Dec 6, 2018
@kdinev kdinev deleted the rkolev/toolbar-template-6.2.x branch December 6, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev approved these changes

@rkaraivanov rkaraivanov rkaraivanov left review comments

@simeonoff simeonoff simeonoff left review comments

Assignees

@tachojelev tachojelev

Labels
grid: toolbar version: 6.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rmkrmk @tachojelev @kdinev @simeonoff @rkaraivanov