Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IgxGrid] Typing in a [dataType]="'date'" cell does not change cell value #5437

Closed
ViktorSlavov opened this issue Jul 16, 2019 · 0 comments · Fixed by #5542
Closed

[IgxGrid] Typing in a [dataType]="'date'" cell does not change cell value #5437

ViktorSlavov opened this issue Jul 16, 2019 · 0 comments · Fixed by #5542
Assignees
@nrobakova
Labels
🐛 bug Any issue that describes a bug 📅 date-picker 🧨 severity: medium grid: cell-editing grid: general grid: hierarchical-grid grid: tree-grid 🛠️ status: in-development Issues and PRs with active development on them version: 7.3.x version: 8.0.x version: 8.1.x

Comments

@ViktorSlavov
Copy link
Contributor

Description

When editing a cell w/ dataType="cell" by typing in it (w/o opening the calendar), the changes are not reflected in the cell's value.

  • igniteui-angular version: 8.0.x
  • browser: N/A

Steps to reproduce

  1. Open the grid editing sample
  2. Enter edit mode in the OrderDate cell of the first row (Chai)
  3. Ctrl + A to select all the text and type 02022002 (02/02/2002)
  4. Press Tab or Enter

Result

The cell value is still 12/02/2012

Expected result

The cell value should be 02/02/2002

Additional Info

The cell template value changte is handled in datePicker.onSelection, which doesn't seem to be emitted when typing
@nrobakova nrobakova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jul 26, 2019
@nrobakova nrobakova assigned nrobakova and unassigned zdrawku Jul 26, 2019
nrobakova added a commit that referenced this issue Jul 29, 2019
@nrobakova
fix(datePicker): Add onValueChanged to handle input changes #5437
9c44bd6
@nrobakova nrobakova mentioned this issue Jul 29, 2019
Merged
14 tasks
nrobakova added a commit that referenced this issue Jul 29, 2019
@nrobakova
fix(datePicker): Add onValueChanged to handle input changes #5437
a43a114
@nrobakova nrobakova mentioned this issue Jul 29, 2019
Merged
14 tasks
nrobakova added a commit that referenced this issue Jul 29, 2019
@nrobakova
fix(datepicker): change event to be called after the setting of value #…
d6c5f51 
…5437
nrobakova added a commit that referenced this issue Jul 30, 2019
@nrobakova
fix(date-picker): Update valueChange to return only new value #5437
41716c9
nrobakova added a commit that referenced this issue Jul 30, 2019
@nrobakova
fix(date-picker): Update valueChange to return only new value #5437
59f5ecc
@kdinev kdinev mentioned this issue Aug 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrobakova nrobakova

Labels
🐛 bug Any issue that describes a bug 📅 date-picker 🧨 severity: medium grid: cell-editing grid: general grid: hierarchical-grid grid: tree-grid 🛠️ status: in-development Issues and PRs with active development on them version: 7.3.x version: 8.0.x version: 8.1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merging 8.1.x into master IgniteUI/igniteui-angular
3 participants
@zdrawku @nrobakova @ViktorSlavov