Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date picker event onValueChanged and use it to update cell value when column type is date #5535

Merged
merged 12 commits into from
Aug 5, 2019
Merged

Add date picker event onValueChanged and use it to update cell value when column type is date #5535

merged 12 commits into from
Aug 5, 2019

Conversation

nrobakova
Copy link
Contributor

@nrobakova nrobakova commented Jul 29, 2019 •
edited by Lipata
Loading

Closes #5437
Closes #4881

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@nrobakova nrobakova changed the title Nrobakova/fix issue 5437 Add date picker event onValueChanged and use it to update cell value when column type is date Jul 29, 2019
@nrobakova nrobakova added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 29, 2019
@PlamenaMiteva PlamenaMiteva added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 30, 2019
wnvko
wnvko previously approved these changes Jul 30, 2019
View reviewed changes
@PlamenaMiteva PlamenaMiteva removed the 💥 status: in-test PRs currently being tested label Jul 31, 2019
@PlamenaMiteva PlamenaMiteva added the ✅ status: verified Applies to PRs that have passed manual verification label Jul 31, 2019
@Lipata Lipata merged commit 57b418b into 8.1.x Aug 5, 2019
@Lipata Lipata deleted the nrobakova/fix-issue-5437 branch August 5, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@Lipata Lipata Lipata approved these changes

@wnvko wnvko wnvko left review comments

@ddincheva ddincheva Awaiting requested review from ddincheva

Assignees

@PlamenaMiteva PlamenaMiteva

Labels
📅 date-picker grid: cell-editing grid: general grid: tree-grid version: 8.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nrobakova @Lipata @damyanpetev @wnvko @PlamenaMiteva @kdinev