Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IgxCombo] - Combo events do not properly expose owner #8326

Closed
ViktorSlavov opened this issue Oct 9, 2020 · 1 comment · Fixed by #8347
Closed

[IgxCombo] - Combo events do not properly expose owner #8326

ViktorSlavov opened this issue Oct 9, 2020 · 1 comment · Fixed by #8347
Assignees
@ViktorSlavov
Labels
📖 documentation 🐛 bug Any issue that describes a bug combo version: 10.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ViktorSlavov
Copy link
Contributor

Description

The IgxComboComponent's onOpening and onClosing events do not property expose the owner property.
onOpened and onClosed events are emitting void, so those can be looked at as well.

Combo API should be cleaned up (IgxComboItemComponent is not exposed in the API docs).

  • igniteui-angular version: 10.1.x
  • browser: N/A
@ViktorSlavov ViktorSlavov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Oct 12, 2020
@Lipata Lipata removed their assignment Oct 12, 2020
ViktorSlavov added a commit that referenced this issue Oct 12, 2020
@ViktorSlavov
fix(combo, dropdown): emit owner in opening and closing events, #8326
de6aa70
@ViktorSlavov ViktorSlavov mentioned this issue Oct 12, 2020
Merged
14 tasks
@ViktorSlavov ViktorSlavov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 13, 2020
@ViktorSlavov
Copy link
Contributor Author

#8347 addresses the combo events. The API cleanup should be addressed in a separate PR.

Lipata pushed a commit that referenced this issue Oct 13, 2020
@ViktorSlavov
fix(combo, dropdown): emit owner in opening and closing events, #8326 (…
71eb4d3 
…#8347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktorSlavov ViktorSlavov

Labels
📖 documentation 🐛 bug Any issue that describes a bug combo version: 10.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(combo, dropdown): emit owner in opening and closing events, #8326 IgniteUI/igniteui-angular
2 participants
@Lipata @ViktorSlavov