Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combo, dropdown): emit owner in opening and closing events, #8326 #8347

Merged
merged 7 commits into from
Oct 13, 2020
Merged

fix(combo, dropdown): emit owner in opening and closing events, #8326 #8347

merged 7 commits into from
Oct 13, 2020

Conversation

ViktorSlavov
Copy link
Contributor

@ViktorSlavov ViktorSlavov commented Oct 12, 2020 •
edited by Lipata
Loading

Closes #8326

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ViktorSlavov ViktorSlavov force-pushed the vslavov/combo-events-owner branch from 08590c4 to a440bb6 Compare October 13, 2020 04:40
@ViktorSlavov ViktorSlavov mentioned this pull request Oct 13, 2020
Closed
@ViktorSlavov ViktorSlavov requested a review from wnvko October 13, 2020 07:00
wnvko
wnvko approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the Wiki pages when this is merged!

@valadzhov valadzhov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 13, 2020
@valadzhov
Copy link
Collaborator

valadzhov commented Oct 13, 2020 •
edited
Loading

The PR is working correctly although the date picker and the select are not emitting the proper arguments but this will be fixed with #8353

@valadzhov valadzhov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 13, 2020
@Lipata Lipata merged commit 71eb4d3 into master Oct 13, 2020
@Lipata Lipata deleted the vslavov/combo-events-owner branch October 13, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnvko wnvko wnvko approved these changes

@Lipata Lipata Lipata approved these changes

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

Assignees

@valadzhov valadzhov

Labels
combo dropdown version: 10.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IgxCombo] - Combo events do not properly expose owner
4 participants
@ViktorSlavov @valadzhov @Lipata @wnvko