Allow both -R/-r and -F #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There doesn't seem to be any reason not to allow analysis from a freq_file while also restricting to certain regions. This also removes the auto-usage of the frq_file as the regions in bcf_sr, which works around some unused SNPs as described in Illumina#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #31 by removing the code preventing -r/-R and -F from both being used in kin, and also removes the default of using the
frq_fileas theregionsfor bcf synced reader.The prior behavior would still be available by specifying the same file as both
-Rand-F.Bonus commit: fixes a typo in an error message.