Improve gitlab .apk retrieval (#1450, #1381, #1380) #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So this code does focus on the official Gitlab REST API. With this the retrieval logic changes.
This may prepare for later refactorings and code simplification
It turned out: If the parameter `private_token` is given but empty, the Gitlab REST API does expect a valid access token otherwise responds with an authorization error
|
Are there any texts in the UI which should have been updated, too? |
ImranR98
pushed a commit
that referenced
this pull request
Mar 9, 2024
ImranR98
added a commit
that referenced
this pull request
Mar 9, 2024
Removed outdated translations related to #1459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obtainium 1.0.4 has two strategies to retrieve .apk information from Gitlab: This is either (a) by using the Gitlab API with a Private Access Token (PAT) or either (b) by using the tags-page of a repository. In some cases (e.g. Aurora Store) the tags-page does not have information about related .apk files, but the Gitlab API has (#1450, #1381, #1380).
This patch removes the tags-page as an information provider and simplifies the retrieval logic. As it turned out: Gitlab's REST API works without
Private Access Tokenauthentication for public repositories. So thePrivate Access Tokenis optional in case authentication is required.Previous discussion: #1438
Tested with
Android 14on an emulated AVDNotice: I haven't tested this patch with private repositories and/or private Gitlab instances yet.