Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gitlab .apk retrieval (#1450, #1381, #1380) #1459

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Improve gitlab .apk retrieval (#1450, #1381, #1380) #1459

merged 4 commits into from
Mar 9, 2024

Commits on Mar 9, 2024

  1. Remove .apk retrieval from tags-feed 

    So this code does focus on the official Gitlab REST API. With this the retrieval logic changes.
    @akramer-zibra
    akramer-zibra committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    a9159fc View commit details
    Browse the repository at this point in the history

  2. Regroup functions by their intention 

    This may prepare for later refactorings and code simplification
    @akramer-zibra
    akramer-zibra committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    3824b38 View commit details
    Browse the repository at this point in the history

  3. Inject Private Access Token as optional request param 

    It turned out: If the parameter `private_token` is given but empty, the Gitlab REST API does expect a valid access token otherwise responds with an authorization error
    @akramer-zibra
    akramer-zibra committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    bb1dd4e View commit details
    Browse the repository at this point in the history

  4. Remove unused package import

    @akramer-zibra
    akramer-zibra committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    d8cd3b6 View commit details
    Browse the repository at this point in the history