Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/code quality control #16

Merged
merged 7 commits into from
Nov 5, 2022
Merged

test/code quality control #16

merged 7 commits into from
Nov 5, 2022

Conversation

anwalker293
Copy link
Contributor

Code to clean up + format all files on either the main branch or the feature/revocation branch.

Requesting to first merge this PR on the feature/revocation branch :)

Alexandra N. Walker alex.walker@indicio.tech ☀️

@dbluhm
Copy link
Member

dbluhm commented Nov 3, 2022

Thanks for the PR! We seem to have commits from main mixed in with this branch; could we clean this up? Only the last 5 commits are changes relevant for adding the GHA for checking code quality

@dbluhm dbluhm mentioned this pull request Nov 3, 2022
@dbluhm
Copy link
Member

dbluhm commented Nov 5, 2022

@anwalker293 I pushed a few minor tweaks 🙂 Wanted to call out the remove of the Authored by line; since you committed the file, your name will be in the git history. Having authorship tracked that way is easier because git will track changes to specific lines. The exact author of a given part of a file is dynamic 🙂 Fully want to give you credit for your work, it'll just be in the git history rather than in the file contents itself.

dbluhm
dbluhm previously approved these changes Nov 5, 2022
Copy link
Member

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dbluhm dbluhm changed the base branch from feature/revocation to main November 5, 2022 18:27
@dbluhm dbluhm dismissed their stale review November 5, 2022 18:27

The base branch was changed.

anwalker293 and others added 7 commits November 5, 2022 14:29
Signed-off-by: Alex Walker <87383822+anwalker293@users.noreply.github.com>
Signed-off-by: Alex Walker <87383822+anwalker293@users.noreply.github.com>
Changing poetry black commands

Alexandra N. Walker <alex.walker@indicio.tech> ☀️

Signed-off-by: Alex Walker <87383822+anwalker293@users.noreply.github.com>
Pushing to run test

Signed-off-by: Alex Walker <87383822+anwalker293@users.noreply.github.com>
Signed-off-by: Alex Walker <87383822+anwalker293@users.noreply.github.com>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm dbluhm merged commit 5af0912 into Indicio-tech:main Nov 5, 2022
@anwalker293 anwalker293 deleted the test/code-quality-control branch November 16, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants