test/tests #17
Merged
test/tests #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to include the code-quality-check GHA from PR #16; what's your intent for this PR? 🙂 |
Signed-off-by: Alex Walker <87383822+anwalker293@users.noreply.github.com>
dbluhm
requested changes
Nov 15, 2022
Signed-off-by: Alex Walker <87383822+anwalker293@users.noreply.github.com>
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
dbluhm
reviewed
Nov 17, 2022
| branches: | ||
| - main | ||
| - feature/** | ||
| - feat/** |
There was a problem hiding this comment.
Nitpick: I prefer the naming scheme feature/** over feat/** (though feat: adsfasdf is what we use in the commit message itself); I think we should remove the feat/** to help enforce that convention 🙂
|
So looks like checks are failing due to the test_credential_attachments module somehow making it onto this branch; I'll take a look at doing a bit of history rewriting to make sure that was never included (as opposed to having an addition at some point in the past and then a removal now) |
|
Test failures should be fixed after we merge main into feature/revocation so I'm going to go ahead and merge this one. Thanks! |
dbluhm
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests.yml fine, running
poetry run tests:)Alexandra N. Walker alex.walker@indicio.tech ☀️