Undefined methodName in error() #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oseiskar
reviewed
Sep 20, 2019
| @@ -95,7 +95,8 @@ function IndoorAtlas() { | |||
| // none of the Cordova callbacks are supposed to fail, always report | |||
| // as status OUT_OF_SERVICE if something like this happens | |||
| function error(result) { | |||
| var message = 'internal error' + methodName + ' failed ' + JSON.stringify(result); | |||
| //var message = 'internal error' + methodName + ' failed ' + JSON.stringify(result); | |||
| var message = 'internal error ' + JSON.stringify(result); | |||
There was a problem hiding this comment.
You're right, this line is the correct version. We'll merge 5029fc5 in the near future. Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I called setPosition, it tried to report that I had the wrong number of elements in my arg array (see #38 regarding this other issue), but it was unable to show me that message because methodName was undefined in error().
(pls ignore the repeat of 'Fixed Android initial install crash bug.' -- I didn't do my branches and pull requests quite right).
Thanks!