same setPosition array vs. object fix for Android -- src/android/IALocationPlugin.java #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @RealHandy! I'm pleased to let you know that the reported issues in #39, #38 and #37 should be now fixed in the latest release of IA Cordova plugin (version 3.1.0). Thank you very much for reporting! |
|
Great! Thank you!
… On Oct 11, 2019, at 7:35 AM, jalaluhtala ***@***.***> wrote:
Hi @RealHandy!
I'm pleased to let you know that the reported issues in #39, #38 and #37 should be now fixed in the latest release of IA Cordova plugin (version 3.1.0). Thank you very much for reporting!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
gitjuba
added a commit
that referenced
this pull request
Feb 24, 2020
gitjuba
added a commit
that referenced
this pull request
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a terrible noob at git complexities, so please ignore everything on this pull request except IALocationPlugin.java -- it's the same fix as provided for iOS in "Fix setPosition location to be NSDictionary of coordinates 2fadf90".
In this Android one, once the JSONArray was changed to a JSONObject to avoid the runtime conversion failure error, the deprecated values were then getting the string "null" instead of null, so the code was returning an initialization error. I just commented that part out so that the code would continue to the rest of the array/object fix.
Sorry again for the PR having so many repeats and ugly extras. All you need is IALocationPlugin.java in "setPosition array vs object error (Java version) 5011890"