Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e10s] Favicons permanently disappear from tabs #224

Closed
modrzew opened this issue Jun 17, 2016 · 5 comments
Closed

[e10s] Favicons permanently disappear from tabs #224

modrzew opened this issue Jun 17, 2016 · 5 comments

Comments

@modrzew
Copy link

modrzew commented Jun 17, 2016

Private Tab seems to make favicons disappear from tabs. This doesn't happen immediately, but after browsing for a while (in my case, a couple days). There isn't even a default icon visible - after loading, spinner disappears and favicon never loads. Restarting browser, or even clearing moz_favicons table in places database doesn't help. Refreshing browser's profile helps, but only for a few days. Turning this addon off finally solved the issue.

Private Tab 0.1.9.1
Firefox 48 b1
Linux Mint 17.3

@Shaxine
Copy link

Shaxine commented Jun 23, 2016

Same for me, but I'm on:
Firefox Nightly 50.0a1
elementaryOS 0.3.2 Freya (64-bit)

@tuxitop
Copy link

tuxitop commented Aug 22, 2016

I'm also facing this problem on Firefox Aurora 50.0a2 with e10s enabled. seems like on a non e10s window favicons are shown with no problem, so It's probably a compatibility problem with e10s.

@Infocatcher Infocatcher changed the title Favicons permanently disappear from tabs [e10s] Favicons permanently disappear from tabs Aug 22, 2016
Infocatcher added a commit that referenced this issue Aug 22, 2016
(to not break regular favicons)
(#208, #224)
@Infocatcher
Copy link
Owner

I've added some fixes...

Test version: private_tab-0.1.9.2pre6-fx-sm.xpi (source code).

@Shaxine
Copy link

Shaxine commented Aug 22, 2016

It seems to be working fine for now, thanks.

I'm on Firefox Nightly 51.0a1 and I will let you know if anything goes south.

@tuxitop
Copy link

tuxitop commented Aug 23, 2016

It's also fixed here. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants