[e10s] Get rid "unsafe CPOW usage", this raise an error in Firefox 47.0a1+ #208

Infocatcher · 2016-01-30T17:04:13Z

So, we can't use PrivateBrowsingUtils.isWindowPrivate(gBrowser.contentWindowAsCPOW) anymore...

(workaround for #208)

sylveon · 2016-01-30T17:38:50Z

I also found something else:
12:37:20,473 Only internal code is allowed to set the usePrivateBrowsing attribute bootstrap.js:3557:2
Trigerred when opening a new private tab.

Infocatcher · 2016-01-30T17:56:40Z

This warning exists for years... and accessing to usePrivateBrowsing attribute is the only way to make tab private.
Briefly described here: https://addons.mozilla.org/addon/private-tab/#developer-comments

sylveon · 2016-01-30T17:57:13Z

Ah. Okay

sylveon · 2016-02-01T17:52:37Z

I got these log entries when disabling and renabling the addon (latest stable), which is totally broken in my Nightly (up-to-date).

12:50:01,432 1454349001432  addons.xpi  WARN    Add-on privateTab@infocatcher is missing bootstrap method shutdown
12:50:01,434 Could not read chrome manifest 'file:///C:/Program%20Files/Nightly/chrome.manifest'.
12:50:01,557 Use of nsIFile in content process is deprecated. Content.js:23:17
12:50:05,059 1454349005058  addons.xpi  WARN    Error loading bootstrap.js for privateTab@infocatcher: SyntaxError: missing ] after element list (resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@infocatcher.xpi!/bootstrap.js:1569:22) JS Stack trace: @XPIProvider.jsm:4482:1 < this.XPIProvider.loadBootstrapScope@XPIProvider.jsm:4482:7 < this.XPIProvider.callBootstrapMethod@XPIProvider.jsm:4558:9 < this.XPIProvider.updateAddonDisabledState@XPIProvider.jsm:4726:13 < AddonWrapper.prototype.userDisabled@XPIProvider.jsm:7013:9 < gViewController.commands.cmd_enableItem.doCommand@extensions.js:1140:9 < gViewController.doCommand@extensions.js:1449:5 < initialize/<@extensions.js:104:5 < EventListener.handleEvent*initialize@extensions.js:103:3 < EventListener.handleEvent*@extensions.js:78:1

Infocatcher · 2016-02-01T18:00:12Z

(latest stable)

With version 0.1.9?
This is due to already fixed #203.

sylveon · 2016-02-01T18:03:35Z

Sorry, I completely forgot about Firefox's addon validation times. I thought it already made it.

(related to #208)

(#208)

(releted to #208, now we can't get state synchronously)

(#162, #208)

(to avoid "unsafe CPOW usage" warnings) (#208)

(#162, #208)

Note: may be wrong… (#162, #208)

(#208)

(looks like not needed… and doesn't work anyway) (#208)

(#208)

Infocatcher · 2016-04-16T18:12:43Z

Test version: private_tab-0.1.9.2pre2-fx-sm.xpi (source code)

sylveon · 2016-04-17T00:08:26Z

This beta version fixed all the problems that I had with Firefox Nightly.

* unsafe CPOW usage (#208) * updated pt-PT locale (#210) * e10s: fixed private protocol (#211) * e10s: tweaks and fixes (#162) * e10s: single frame script (#213) * fixed recursion in wrapper for tab.setAttribute("image", …) (#214) * compatibility with Firefox 51+: broked this.windows getter (#228) * small internal enhancements and fixes

(to not break regular favicons) (#208, #224)

(#208, #224)

Infocatcher added bug compatibility labels Jan 30, 2016

Infocatcher added a commit that referenced this issue Jan 30, 2016

Fallback to use tab attribute, if check for content window failed

19d1f63

(workaround for #208)

Infocatcher mentioned this issue Feb 1, 2016

Private Tab share same cookies as a normal tab #206

Closed

Infocatcher mentioned this issue Feb 9, 2016

Private Tab stills appear on a private browsing window and breaks it when used #209

Closed

Infocatcher added a commit that referenced this issue Feb 9, 2016

Workaround for broken documentURIObject from CPOW

0942b29

(related to #208)

Infocatcher added a commit that referenced this issue Feb 26, 2016

Get real tab state using frame script

70ceefe

(#208)

Infocatcher added a commit that referenced this issue Feb 26, 2016

Don't check real state of restored tab in multi-process mode

7c18fb7

(releted to #208, now we can't get state synchronously)

Infocatcher added a commit that referenced this issue Feb 26, 2016

Reduce error messages and tweak debug logs

a399940

(#162, #208)

Infocatcher mentioned this issue Mar 1, 2016

[e10s] Use only one frame script for communications with remote tabs #213

Closed

Infocatcher added a commit that referenced this issue Mar 1, 2016

Don't call getTabPrivacyContext() for remote tabs

9a5657b

(to avoid "unsafe CPOW usage" warnings) (#208)

Infocatcher added a commit that referenced this issue Mar 1, 2016

toggleTabPrivate(): check for last private tab in multi-process mode

71cb4f7

(#162, #208)

Infocatcher added a commit that referenced this issue Mar 1, 2016

toggleTabPrivate(): restore return value in multi-process mode

80e15c8

Note: may be wrong… (#162, #208)

Infocatcher added a commit that referenced this issue Mar 3, 2016

Use more documented way to detect remote tabs

8b2c8a5

(#208)

Infocatcher added a commit that referenced this issue Mar 3, 2016

Avoid CPOWs in code to open private tabs from page context menu

2ecb22d

(#208)

Infocatcher added a commit that referenced this issue Mar 3, 2016

Avoid CPOWs in isPrivateContent()

afbe4a8

(#208)

Infocatcher added a commit that referenced this issue Mar 3, 2016

Don't use contentDocumentAsCPOW in workaround for restored tabs

3eb2a7d

(looks like not needed… and doesn't work anyway) (#208)

Infocatcher added a commit that referenced this issue Mar 4, 2016

Avoid CPOWs in wrapper for browser.loadURIWithFlags() + simplify

6fef2c5

(#208)

Infocatcher mentioned this issue Mar 6, 2016

[e10s] Get rid "unsafe CPOW usage", this raise an error in Firefox 47.0a1+ Infocatcher/Link_Properties_Plus#20

Closed

Infocatcher mentioned this issue Apr 16, 2016

[e10s] Doesn't work with enabled Electrolysis (multi-process mode) #162

Closed

5 tasks

Infocatcher added a commit that referenced this issue Aug 22, 2016

Workaround in fix for favicon of image documents

205b098

(to not break regular favicons) (#208, #224)

Infocatcher added a commit that referenced this issue Aug 22, 2016

Refactor fix for favicon of image documents

207f152

(#208, #224)

Infocatcher added a commit that referenced this issue Aug 22, 2016

Get favicon of image documents in e10s mode

282a726

(#208, #224)

Infocatcher added a commit that referenced this issue Aug 22, 2016

Simplify favicons handling in non-e10s mode

c76db27

(#208, #224)

Infocatcher added a commit that referenced this issue Aug 24, 2016

Limit size of debug logs from setTabAttributeProxy()

2bac717

(#208, #224)

Infocatcher added a commit that referenced this issue Aug 25, 2016

Slightly refactor setTabAttributeProxy() for better readability

fa63385

(#208, #224)

Infocatcher closed this as completed Aug 25, 2016

Infocatcher mentioned this issue Sep 11, 2016

[e10s] Don't use CPOWs #234

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[e10s] Get rid "unsafe CPOW usage", this raise an error in Firefox 47.0a1+ #208

[e10s] Get rid "unsafe CPOW usage", this raise an error in Firefox 47.0a1+ #208

Infocatcher commented Jan 30, 2016

sylveon commented Jan 30, 2016

Infocatcher commented Jan 30, 2016

sylveon commented Jan 30, 2016

sylveon commented Feb 1, 2016

Infocatcher commented Feb 1, 2016

sylveon commented Feb 1, 2016

Infocatcher commented Apr 16, 2016

sylveon commented Apr 17, 2016

[e10s] Get rid "unsafe CPOW usage", this raise an error in Firefox 47.0a1+ #208

[e10s] Get rid "unsafe CPOW usage", this raise an error in Firefox 47.0a1+ #208

Comments

Infocatcher commented Jan 30, 2016

sylveon commented Jan 30, 2016

Infocatcher commented Jan 30, 2016

sylveon commented Jan 30, 2016

sylveon commented Feb 1, 2016

Infocatcher commented Feb 1, 2016

sylveon commented Feb 1, 2016

Infocatcher commented Apr 16, 2016

sylveon commented Apr 17, 2016