Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: External links feature branch #1306

Draft
wants to merge 108 commits into
base: master
Choose a base branch
from
Draft

feat: External links feature branch #1306

wants to merge 108 commits into from
+3,736 −754

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Sep 27, 2024 •
edited
Loading

Abstract

Feature PR of the external links

Core tasks so far:

  • Network calls
  • In memory realm for each share link
  • Propagate context to preview controller and subsequent FileListViewController

Merged PRs:

sub PRs to review:
~~

sub PRs DRAFT:

  • Last details
  • Ajust action sheets size inset
  • DownloadAll display progress

⚠ Must change deeplink handling backend side when the app is live.

@adrien-coye
chore: WIP endpoints
3b54164
@adrien-coye
feat: In memory realm for external share context
2046680
@adrien-coye
fix: Project builds
001219f
@adrien-coye
feat: Public share metadata WIP
31eafba
@adrien-coye
feat(Rights): Updated to be compatible with public share
98cffec
@adrien-coye
feat(PublicShareMetadata): Parsing pass
fe5772f
@adrien-coye
refactor(Endpoint): Split files into dedicated extensiions
1aff48b 
feat(Endpoint): Finish the external links endpoint implementation
@adrien-coye
feat: Fetch root folder for a public share
772ac0d
@adrien-coye
feat: Cursored public share children query
e1c1644
@adrien-coye
feat: Can natively show a public share within the app
84fa7fd
@adrien-coye
fix(FilePresenter): Present public share in context
130305f
@adrien-coye
fix: Capabilities for Public Share
0b48b91
@adrien-coye
feat: Thumbnails on public share
272968e
@adrien-coye
feat: Can navigate hierarchy of public share folders
4e48460 
refactor: Simplified code
@adrien-coye
feat: Preview for public share
3bdf94e
@adrien-coye adrien-coye marked this pull request as draft September 27, 2024 07:27
@adrien-coye adrien-coye added the feature A new functionality is added to the product label Sep 27, 2024
@adrien-coye adrien-coye mentioned this pull request Dec 5, 2024
Merged
@adrien-coye adrien-coye mentioned this pull request Dec 6, 2024
Draft
6 tasks
@adrien-coye adrien-coye mentioned this pull request Dec 30, 2024
Merged
@adrien-coye
chore: PR Feedback
42a8b05
@adrien-coye
refactor(DownloadOperation): Split into subclasses (#1367)
f3c9853
@adrien-coye
chore: Merge branch 'feature-externalLinks' into externalLinks-multiS…
20ff0ef 
…elect
@adrien-coye
refactor(DownloadArchiveOperation): Split dedicated public share code
3ff747c
@adrien-coye
refactor(DownloadArchiveOperation): Factorised download request
d96e98d
@adrien-coye
refactor(DownloadArchiveOperation): Split code related to publicShare (…
17109b6 
…#1368)
@adrien-coye
refactor(DownloadOperation): Renamed DownloadAuthenticatedOperation
62ddb92
@adrien-coye
refactor(DownloadOperationable): Renamed DownloadFileOperationable
351a198
@adrien-coye
chore(DownloadOperation): Explicit sendable requirements from base Op…
2d60725 
…eration class
@adrien-coye
refactor(DownloadOperation): Factorise a base DownloadOperation.
052442b
@adrien-coye
chore: Sonar naming conventions
e93a347
@adrien-coye
chore: Merge branch 'master' into feature-externalLinks
b3fe62d
@adrien-coye
chore: Merge branch 'feature-externalLinks' into externalLinks-multiS…
2825da0 
…elect
@adrien-coye
chore: Merge branch 'externalLinks-multiSelect' into externalLinks-co…
24b3fec 
…mmon-download-operation
@adrien-coye
refactor(DownloadOperation): Public accessor for progress value
399acfb
@adrien-coye
refactor: Common download operation (#1370)
cc16b7a
@adrien-coye
refactor(DownloadQueue): Use abstract type DownloadFileOperationable …
d294a79 
…in operationsInQueue
@adrien-coye
feat: Multiselect behaviour (#1311)
c1f7fb4
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
5 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature A new functionality is added to the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrien-coye @PhilippeWeidmann @valentinperignon