refactor(DownloadOperation): Split into subclasses #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
requested review from
PhilippeWeidmann and
lebojo
and removed request for
PhilippeWeidmann
adrien-coye
force-pushed
the
refactor-download-operation
branch
from
d7984bd to
0afa9b3
Compare
20 tasks
|
I tested that it works for both public share and normal drive. All good. |
lebojo
reviewed
Dec 30, 2024
kDriveCore/Data/DownloadQueue/DownloadOperation/DownloadOperation.swift
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits publicShare DownloadOperation into a dedicated type.
Feature branch #1306