Skip to content

Design Basic style guide #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenucksi opened this issue May 11, 2020 · 1 comment
Closed

Design Basic style guide #171

lenucksi opened this issue May 11, 2020 · 1 comment
Assignees
@maxcapraro
Labels
⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR

Comments

@lenucksi
Copy link
Member

lenucksi commented May 11, 2020 •
edited by spier
Loading

We should develop an initial version of a basic style guide, which will be used to validate patterns against the requirements of Level 2 - Structured. This is a follow up on PR #155.

(Edited by @maxcapraro)
@lenucksi lenucksi mentioned this issue May 11, 2020
Merged
4 tasks
@maxcapraro maxcapraro changed the title Make an issue for the **basic style guide** Design basic style guide May 21, 2020
@maxcapraro maxcapraro added the ⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR label May 21, 2020
@spier spier changed the title Design basic style guide Design Basic style guide Dec 27, 2020
@spier spier mentioned this issue Dec 27, 2020
Closed
spier added a commit that referenced this issue Jan 22, 2022
@spier
Adding basic Style Guide, including the pattern naming conventions an…
1416855 
…d the start of a Glossary. Implements #170 and #171 (although there is still plenty to do in this space).
@spier spier mentioned this issue Jan 22, 2022
Merged
spier added a commit that referenced this issue Jan 24, 2022
@spier
Add details of review process to Contributor Handbook (#273)
1ad084a 
Document more for of the unspoken/implicit review requirements.

Details:
- Adds information about automatic checks and unspoken review expectations. 
- Adds where the output artifacts in each level are kept.
- Addis basic Style Guide, including the pattern naming conventions and the start of a Glossary. Implements #170 and #171.
@spier
Copy link
Member

spier commented Jan 24, 2022

A Basic style guide is now available at
https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/meta/pattern-style-guide.md

@spier spier closed this as completed Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxcapraro maxcapraro

Labels
⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spier @lenucksi @maxcapraro