-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details of review process to Contributor Handbook #273
Conversation
…ons. Also adds where the output artifacts in each level are kept.
@maxcapraro as you wrote the first version of the Contributor Handbook, can you help us understand the intended semantic difference between the Validation requirements and Content requirements? Understanding this better will help to make better decisions about which info to put where. |
@tapjdey @WillemJiang as you have made your first contributes to our Patterns recently, it would be great to get your feedback here. This PR tries to explain better how we go about reviewing patterns. You can focus your feedback on levels 1 and 2, as we don't have level 3 patterns yet. If you have any further thoughts about this, let us know. And thanks for you help! |
@robtuley as you recently worked on a pattern, I was wondering if you could review if this PR here is a helpful improvement for the documentation in our Contributor Handbook? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a helpful update to me as a recent contributor.
We have used the new maturity levels for the patterns for over a year now.
I figured we could aggregate our working knowledge in the Contributor Handbook, to make it easier for new contributors to understand what we are after when using the different maturity levels.
This PR also starts to implement #170 and #171.
Changes made: