[Splash] use directly QSplashScreen & update splash MSC logos #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcollot
requested changes
Nov 29, 2023
| @@ -146,6 +170,9 @@ void medApplication::setMainWindow(medMainWindow *mw) | |||
| QVariant var = QVariant::fromValue((QObject*)d->mainWindow); | |||
| this->setProperty("MainWindow",var); | |||
| d->systemOpenInstructions.clear(); | |||
|
|
|||
| // Wait until the app is displayed to close itself | |||
| d->splashScreen->finish(d->mainWindow); | |||
There was a problem hiding this comment.
The close function will be called on the splash screen, but this does not delete the widget unless the attribute Qt::WA_DeleteOnClose is set.
There was a problem hiding this comment.
Indeed, i added a line and rebased the PR
mathildemerle
force-pushed
the
splashQt2
branch
from
226c3ef to
18eb153
Compare
fcollot
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of medSplashScreen which is not needed anymore, we can use directly QSplashScreen.
It's now launched at the creation of the app (in the beginning of medApplication constructor), and automatically closed when the window of the app is displayed.
This change debugs also a problem at least of Ubuntu side where the splashScreen was not displayed at the right time.
Also, i updated the MUSICardio logos for splash screen.