Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SplashScreen] use directly QSplashScreen & update splash medInria logo #1168

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

mathildemerle
Copy link
Collaborator

As done on MUSICardio side: Inria-Asclepios#800

This PR removes the use of medSplashScreen which is not needed anymore, we can use directly QSplashScreen.

It's now launched at the creation of the app (in the beginning of medApplication constructor), and automatically closed when the window of the app is displayed.

This change debugs also a problem at least of Ubuntu side where the splashScreen was not displayed at the right time.

Also, i updated the medInria splashscreen logo to be a dedicated one (not the same as the one on homepage), with a background color, and no need to space for text.

Ⓜ️

@mathildemerle mathildemerle added this to the 3.4 milestone Nov 23, 2023
@Florent2305
Copy link
Member

At a moment of code review the question was

QSplashScreen *splashScreen

leek or not ?

Thanks to Mathilde investigation, the lines

d->splashScreen->setAttribute(Qt::WA_DeleteOnClose, true);
d->splashScreen->finish(d->mainWindow);

prouve we don't have a leek.

Then for me the PR is good to merge ;)

But a question still open. After the line

d->splashScreen->finish(d->mainWindow);

Do we need a d->splashScreen = nullptr; the answer to this question is in a future discussion...

Copy link
Member

@Florent2305 Florent2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@Florent2305 Florent2305 merged commit e44e5a1 into medInria:medInria3.4.x Jan 19, 2024
@mathildemerle mathildemerle deleted the medSplash3.4 branch January 19, 2024 08:26
@mathildemerle
Copy link
Collaborator Author

as a reminder it's possible to switch QSplashScreen *splashScreen; to QPointer<QSplashScreen> splashScreen; because QPointer set automatically to null the variable if it has been deleted. It's not really useful here but could be helpful in other part of the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants