STYLE: Install MINC's cmake files to lib/cmake #754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Install MINC's cmake files (`itkLIBMINCConfig.cmake` and `UseitkLIBMINC.cmake` into `lib/cmake` not `lib/` - This patch is required to get ITK accepted into the Homebrew package manager - See also Homebrew/homebrew-core#39138
vfonov
pushed a commit
to BIC-MNI/libminc
that referenced
this pull request
Apr 23, 2019
…eed to propagate to all packages using libminc
|
I was about to PR upstream, but it looks like @vfonov beat me to working on it, so I'll leave it alone. |
5 tasks
|
@thewtex: It looks like upstream is patching MINC. Should I close this PR under the assumption that it will be included in the next MINC/ITK release? Please let me know how you think we should proceed. |
Closed
vfonov
added a commit
to vfonov/ITK
that referenced
this pull request
Apr 24, 2019
Run the UpdateFromUpstream.sh script to extract upstream MINC
using the following shell commands.
$ git archive --prefix=upstream-minc/ 44fae20d --
./ChangeLog
./volume_io
./libsrc
./libsrc/minc_compat.h
./libcommon/minc_config.h
./libcommon/minc_config.c
./libsrc/minc_format_convert.c
./libsrc/value_conversion.c
./libsrc/hdf_convenience.c
./libcommon/read_file_names.c
./libsrc/minc_simple.c
./libcommon/time_stamp.h
./libsrc/hdf_convenience.h
./libsrc/type_limits.h
./libcommon/read_file_names.h
./libsrc/minc_varlists.h
./libcommon/restructure.h
./libsrc/nd_loop.h
./libcommon/restructure.c
./libsrc/minc_simple.h
./libsrc/strdup.c
./libsrc/minc_useful.h
./libsrc/minc_convenience.c
./libsrc/minc_basic.h
./libsrc/minc_compat.c
./libcommon/time_stamp.c
./libsrc/voxel_loop.h
./libsrc/minc_routines.h
./libsrc/minc_private.h
./libsrc/netcdf_convenience.c
./libsrc/voxel_loop.c
./libsrc/dim_conversion.c
./libsrc/minc_format_convert.h
./libsrc/nd_loop.c
./libcommon/ParseArgv.h
./libcommon/minc_error.c
./libcommon/minc_error.h
./libsrc/minc_structures.h
./libsrc/minc.h
./libsrc/image_conversion.c
./libcommon/ParseArgv.c
./libcommon/minc_common_defs.h
./COPYING
./UseLIBMINC.cmake.in
./NEWS
./AUTHORS
./libsrc2/m2util.c
./libsrc2/minc2_defs.h
./libsrc2/minc2_api.h
./libcommon/minc2_error.h
./libsrc2/grpattr.c
./libsrc2/hyper.c
./libsrc2/minc_compat2.h
./libcommon/minc2_error.c
./libsrc2/record.c
./libsrc2/volume.c
./libsrc2/datatype.c
./libsrc2/volprops.c
./libsrc2/valid.c
./libsrc2/convert.c
./libsrc2/free.c
./libsrc2/dimension.c
./libsrc2/label.c
./libsrc2/minc2.h
./libsrc2/minc2_private.h
./libsrc2/slice.c
./libsrc2/minc2_structs.h
./CMakeLists.txt
./nifti
./LIBMINCConfig.cmake.in
./README.release
./INSTALL
./config.h.cmake
./README
| tar x
$ git shortlog --perl-regexp --author='^((?!Kitware Robot).*)$' --no-merges --abbrev=8 --format='%h %s' ce4333ca..44fae20d
Vladimir S. FONOV (10):
fd83832f Adopted code from ITK: http://review.source.kitware.com/#/c/23646/ , addresses InsightSoftwareConsortium#99
e78160de Updated list of dependecies in libminc project
b2bba385 Fixing build with ubuntu HDF5 package
361f2b53 Fixing build with ubuntu HDF5 package
9abbd9a0 Fixed a resource leak when dealing with gzipped minc file in minc1_io
e6b27467 Changed configuration files for better integration into conda
9cd436de Fixing configuration files
c2494d2d Fixed mixup in configuration parameters
bcbccf97 Fixed missing quite
44fae20d Trying to implement changes from InsightSoftwareConsortium#754, need to propagate to all packages using libminc
Change-Id: I83f8dce41072978366cf89bd05d177b4dd62d5ee
|
LMK if you're minting a new release of ITK anytime soon. I'm going ahead and green-lighting the Homebrew PR but, so long as the MINC patch makes it into the next release, we'll need to remove the patch we're currently applying in Homebrew. |
|
Thanks, @zbeekman . This has been merged into ITK |
|
Great, thanks!
…On Thu, Apr 25, 2019 at 6:25 AM Matt McCormick ***@***.***> wrote:
Closed #754 <#754>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#754 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACEIPATAK66F6OO6XMLVYDPSGBIVANCNFSM4HHYXMOQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itkLIBMINCConfig.cmakeandUseitkLIBMINC.cmakeintolib/cmakenotlib/PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.