Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: adding new remote modules: Montage and BSplineGradient #99

Merged

Conversation

hjmjohnson
Copy link
Member

http://review.source.kitware.com/#/c/23862/

Dzenan Zukic
Uploaded patch set 1.Nov 2 9:52 AM

Dzenan Zukic
Patch Set 1: BSplineGradient is required by Ultrasound remote module. Montage is not yet finished, but it already has useful abilities.Nov 2 9:54 AM

Kitware Build Robot
Patch Set 1: Verified-1 Build Failed: CDash filtered results: https://open.cdash.org/index.php?&project=Insight&filtercount=3&field1=buildname/string&compare1=63&value1=23862-1&field2=buildstarttime/date&compare2=83&value2=2015-03-01&field3=buildstarttime/date&compare3=84&value3=2029-01-01Nov 2 10:01 AM

Jon Hait... Gorroño
Patch Set 1: Code-Review+1 Matt said a while ago that the module needed further work to be added as a remote (e.g. IJ article etc.), so it may not be completely finished so as to be included: InsightSoftwareConsortium/ITKMontage#51 I guess you are still under tons of work, so I do not mind if that module is postponed.Nov 2 10:51 PM

Modules/Remote/BSplineGradient.cmake Outdated Show resolved Hide resolved
Change-Id: I04f24d03a1102909e23a27ca240a08504976d662
@hjmjohnson hjmjohnson closed this Nov 6, 2018
@hjmjohnson hjmjohnson deleted the addNewRemotes branch November 6, 2018 14:49
@hjmjohnson hjmjohnson restored the addNewRemotes branch November 6, 2018 19:22
@hjmjohnson
Copy link
Member Author

Accidently deleted/closed branch when the script for moving from Gerrit went haywire.

@hjmjohnson hjmjohnson reopened this Nov 6, 2018
@hjmjohnson
Copy link
Member Author

hjmjohnson commented Nov 7, 2018

@thewtex Requested changes made.

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hjmjohnson hjmjohnson merged commit 9ba00fd into InsightSoftwareConsortium:master Nov 7, 2018
@hjmjohnson hjmjohnson deleted the addNewRemotes branch April 17, 2019 16:17
thewtex pushed a commit to thewtex/ITK that referenced this pull request Apr 24, 2019
Run the UpdateFromUpstream.sh script to extract upstream MINC
using the following shell commands.

$ git archive --prefix=upstream-minc/ bcbccf97 -- 
./ChangeLog
./volume_io
./libsrc
./libsrc/minc_compat.h
./libcommon/minc_config.h
./libcommon/minc_config.c
./libsrc/minc_format_convert.c
./libsrc/value_conversion.c
./libsrc/hdf_convenience.c
./libcommon/read_file_names.c
./libsrc/minc_simple.c
./libcommon/time_stamp.h
./libsrc/hdf_convenience.h
./libsrc/type_limits.h
./libcommon/read_file_names.h
./libsrc/minc_varlists.h
./libcommon/restructure.h
./libsrc/nd_loop.h
./libcommon/restructure.c
./libsrc/minc_simple.h
./libsrc/strdup.c
./libsrc/minc_useful.h
./libsrc/minc_convenience.c
./libsrc/minc_basic.h
./libsrc/minc_compat.c
./libcommon/time_stamp.c
./libsrc/voxel_loop.h
./libsrc/minc_routines.h
./libsrc/minc_private.h
./libsrc/netcdf_convenience.c
./libsrc/voxel_loop.c
./libsrc/dim_conversion.c
./libsrc/minc_format_convert.h
./libsrc/nd_loop.c
./libcommon/ParseArgv.h
./libcommon/minc_error.c
./libcommon/minc_error.h
./libsrc/minc_structures.h
./libsrc/minc.h
./libsrc/image_conversion.c
./libcommon/ParseArgv.c
./libcommon/minc_common_defs.h
./COPYING
./UseLIBMINC.cmake.in
./NEWS
./AUTHORS
./libsrc2/m2util.c
./libsrc2/minc2_defs.h
./libsrc2/minc2_api.h
./libcommon/minc2_error.h
./libsrc2/grpattr.c
./libsrc2/hyper.c
./libsrc2/minc_compat2.h
./libcommon/minc2_error.c
./libsrc2/record.c
./libsrc2/volume.c
./libsrc2/datatype.c
./libsrc2/volprops.c
./libsrc2/valid.c
./libsrc2/convert.c
./libsrc2/free.c
./libsrc2/dimension.c
./libsrc2/label.c
./libsrc2/minc2.h
./libsrc2/minc2_private.h
./libsrc2/slice.c
./libsrc2/minc2_structs.h
./CMakeLists.txt
./nifti
./LIBMINCConfig.cmake.in
./README.release
./INSTALL
./config.h.cmake
./README
 | tar x
$ git shortlog --perl-regexp --author='^((?!Kitware Robot).*)$' --no-merges --abbrev=8 --format='%h %s' ce4333ca..bcbccf97

Vladimir S. FONOV (9):
      fd83832f Adopted code from ITK: http://review.source.kitware.com/#/c/23646/ , addresses InsightSoftwareConsortium#99
      e78160de Updated list of dependecies in libminc project
      b2bba385 Fixing build with ubuntu HDF5 package
      361f2b53 Fixing build with ubuntu HDF5 package
      9abbd9a0 Fixed a resource leak when dealing with gzipped minc file in minc1_io
      e6b27467 Changed configuration files for better integration into conda
      9cd436de Fixing configuration files
      c2494d2d Fixed mixup in configuration parameters
      bcbccf97 Fixed missing quite

Change-Id: I4cb4548bf14400f82a02589806e9387b7a5b3505
vfonov added a commit to vfonov/ITK that referenced this pull request Apr 24, 2019
Run the UpdateFromUpstream.sh script to extract upstream MINC
using the following shell commands.

$ git archive --prefix=upstream-minc/ 44fae20d -- 
./ChangeLog
./volume_io
./libsrc
./libsrc/minc_compat.h
./libcommon/minc_config.h
./libcommon/minc_config.c
./libsrc/minc_format_convert.c
./libsrc/value_conversion.c
./libsrc/hdf_convenience.c
./libcommon/read_file_names.c
./libsrc/minc_simple.c
./libcommon/time_stamp.h
./libsrc/hdf_convenience.h
./libsrc/type_limits.h
./libcommon/read_file_names.h
./libsrc/minc_varlists.h
./libcommon/restructure.h
./libsrc/nd_loop.h
./libcommon/restructure.c
./libsrc/minc_simple.h
./libsrc/strdup.c
./libsrc/minc_useful.h
./libsrc/minc_convenience.c
./libsrc/minc_basic.h
./libsrc/minc_compat.c
./libcommon/time_stamp.c
./libsrc/voxel_loop.h
./libsrc/minc_routines.h
./libsrc/minc_private.h
./libsrc/netcdf_convenience.c
./libsrc/voxel_loop.c
./libsrc/dim_conversion.c
./libsrc/minc_format_convert.h
./libsrc/nd_loop.c
./libcommon/ParseArgv.h
./libcommon/minc_error.c
./libcommon/minc_error.h
./libsrc/minc_structures.h
./libsrc/minc.h
./libsrc/image_conversion.c
./libcommon/ParseArgv.c
./libcommon/minc_common_defs.h
./COPYING
./UseLIBMINC.cmake.in
./NEWS
./AUTHORS
./libsrc2/m2util.c
./libsrc2/minc2_defs.h
./libsrc2/minc2_api.h
./libcommon/minc2_error.h
./libsrc2/grpattr.c
./libsrc2/hyper.c
./libsrc2/minc_compat2.h
./libcommon/minc2_error.c
./libsrc2/record.c
./libsrc2/volume.c
./libsrc2/datatype.c
./libsrc2/volprops.c
./libsrc2/valid.c
./libsrc2/convert.c
./libsrc2/free.c
./libsrc2/dimension.c
./libsrc2/label.c
./libsrc2/minc2.h
./libsrc2/minc2_private.h
./libsrc2/slice.c
./libsrc2/minc2_structs.h
./CMakeLists.txt
./nifti
./LIBMINCConfig.cmake.in
./README.release
./INSTALL
./config.h.cmake
./README
 | tar x
$ git shortlog --perl-regexp --author='^((?!Kitware Robot).*)$' --no-merges --abbrev=8 --format='%h %s' ce4333ca..44fae20d

Vladimir S. FONOV (10):
      fd83832f Adopted code from ITK: http://review.source.kitware.com/#/c/23646/ , addresses InsightSoftwareConsortium#99
      e78160de Updated list of dependecies in libminc project
      b2bba385 Fixing build with ubuntu HDF5 package
      361f2b53 Fixing build with ubuntu HDF5 package
      9abbd9a0 Fixed a resource leak when dealing with gzipped minc file in minc1_io
      e6b27467 Changed configuration files for better integration into conda
      9cd436de Fixing configuration files
      c2494d2d Fixed mixup in configuration parameters
      bcbccf97 Fixed missing quite
      44fae20d Trying to implement changes from InsightSoftwareConsortium#754, need to propagate to all packages using libminc

Change-Id: I83f8dce41072978366cf89bd05d177b4dd62d5ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants