-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming "withCollectionView:" param to "collectionView:" in IGListAdapterUpdaterDelegate #466
Labels
Milestone
Comments
11 tasks
4 tasks
4 tasks
facebook-github-bot
pushed a commit
that referenced
this issue
Feb 21, 2017
Summary: - Rename "withCollectionView:" param to "collectionView:" param to be consistent with the rest of the protocol. - Update tests. Related issue: #466 - [x] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes #491 Differential Revision: D4589976 Pulled By: rnystrom fbshipit-source-id: 5e5aa7328a6bbac6baa705d5228f0eb4321d8c31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the updater delegate protocol, this method:
- (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater didPerformBatchUpdates:(IGListBatchUpdateData *)updates withCollectionView:(UICollectionView *)collectionView;
Should read
- (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater didPerformBatchUpdates:(IGListBatchUpdateData *)updates collectionView:(UICollectionView *)collectionView;
To be consistent with the rest of the protocol. Note this is a breaking change.
The text was updated successfully, but these errors were encountered: