-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "withCollectionView:" param to "collectionView:" #491
Conversation
…apterUpdaterDelegate - Rename `didPerformBatchUpdates` param to be consistent with the rest of the protocol. - Update tests.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincent-peng awesome! Mind updating the CHANGELOG.md
since this is a breaking change?
@@ -39,7 +39,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
*/ | |||
- (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater | |||
didPerformBatchUpdates:(IGListBatchUpdateData *)updates | |||
withCollectionView:(UICollectionView *)collectionView; | |||
collectionView:(UICollectionView *)collectionView; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: formatting
@vincent-peng updated the pull request - view changes |
CHANGELOG.md
Outdated
- (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater | ||
didPerformBatchUpdates:(IGListBatchUpdateData *)updates | ||
collectionView:(UICollectionView *)collectionView; | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We probably don't need the old/new here.
What about just saying
Renamed
IGListAdapterUpdaterDelegate
method tolistAdapterUpdater:didPerformBatchUpdates:collectionView:
w/ the name + PR
@vincent-peng updated the pull request - view changes |
@vincent-peng updated the pull request - view changes |
@vincent-peng updated the pull request - view changes |
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
of the protocol.
Changes in this pull request
Related issue: #466
Pull request checklist
CHANGELOG.md
for any breaking changes, enhancements, or bug fixes.