Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "withCollectionView:" param to "collectionView:" #491

Closed
wants to merge 6 commits into from
Closed

Rename "withCollectionView:" param to "collectionView:" #491

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59cf9d8
Renaming "withCollectionView:" param to "collectionView:" in IGListAd…
Feb 14, 2017
a43327c
Code formatting
Feb 15, 2017
6c0c9c8
Update CHANGELOG.md
Feb 15, 2017
790eed6
Update CHANGELOG.md
Feb 15, 2017
eabbf24
Add missing punctuation mark in latest CHANGELOG.md
Feb 15, 2017
55bff86
Merge branch 'master' into master
Feb 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,20 @@ This release closes the [3.0.0 milestone](https://github.com/Instagram/IGListKit

- Replaced `IGListGridCollectionViewLayout` with `IGListCollectionViewLayout`. [[Ryan Nystrom](https://github.com/rnystrom) [(tbd)](https://github.com/Instagram/IGListKit/pull/tbd)

- Renamed `withCollectionView:` param to `collectionView:` in IGListAdapterUpdaterDelegate [Vincent Peng](https://github.com/vincent-peng) [(#491)](https://github.com/Instagram/IGListKit/pull/491)

```objc
// OLD
- (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater
didPerformBatchUpdates:(IGListBatchUpdateData *)updates
withCollectionView:(UICollectionView *)collectionView;

// NEW
- (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater
didPerformBatchUpdates:(IGListBatchUpdateData *)updates
collectionView:(UICollectionView *)collectionView;
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We probably don't need the old/new here.

What about just saying

Renamed IGListAdapterUpdaterDelegate method to listAdapterUpdater:didPerformBatchUpdates:collectionView:

w/ the name + PR


### Enhancements

- You can now manually move items (cells) within a section controller, ex: `[self.collectionContext moveInSectionController:self fromIndex:0 toIndex:1]`. [Ryan Nystrom](https://github.com/rnystrom) [(#418)](https://github.com/Instagram/IGListKit/pull/418)
Expand Down Expand Up @@ -205,3 +219,5 @@ You can find a [migration guide here](https://instagram.github.io/IGListKit/migr
-----

Initial release. :tada:


2 changes: 1 addition & 1 deletion Source/IGListAdapterUpdaterDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ NS_ASSUME_NONNULL_BEGIN
*/
- (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater
didPerformBatchUpdates:(IGListBatchUpdateData *)updates
collectionView:(UICollectionView *)collectionView;
collectionView:(UICollectionView *)collectionView;

/**
Notifies the delegate that the updater will call `-[UICollectionView insertItemsAtIndexPaths:]`.
Expand Down