Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradient monitor callback #144

Merged
merged 210 commits into from
Jun 8, 2023
Merged

Add gradient monitor callback #144

merged 210 commits into from
Jun 8, 2023

Conversation

dxoigmn
Copy link
Contributor

@dxoigmn dxoigmn commented May 5, 2023

What does this PR do?

This adds a gradient monitor callback so that one can make monitor the norm of different gradients.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • No tests

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@dxoigmn dxoigmn requested a review from mzweilin May 22, 2023 23:18
Base automatically changed from adversary_as_lightningmodule to main June 2, 2023 19:33
@mzweilin
Copy link
Contributor

mzweilin commented Jun 6, 2023

Do you have an example? I tried to run this command, but I didn't see gradient logs in Tensorboard.

CUDA_VISIBLE_DEVICES=0 \
python -m mart \
experiment=CIFAR10_CNN_Adv \
fit=false \
trainer=gpu \
+trainer.limit_test_batches=1 \
+callbacks@model.modules.input_adv_test.callbacks=gradient_monitor \
+model.modules.input_adv_test.callbacks.gradient_monitor.frequency=1

Update: patch and example in #164

@dxoigmn
Copy link
Contributor Author

dxoigmn commented Jun 6, 2023

There are no parameters in an Adversary ;) This is why I think it's better to modify the state_dict rather than playing tricks by hiding parameters in lists.

@mzweilin
Copy link
Contributor

mzweilin commented Jun 7, 2023

There are no parameters in an Adversary ;) This is why I think it's better to modify the state_dict rather than playing tricks by hiding parameters in lists.

Resolved in #160

Copy link
Contributor

@mzweilin mzweilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dxoigmn dxoigmn merged commit 08a7393 into main Jun 8, 2023
@dxoigmn dxoigmn deleted the gradient_monitor_callback branch June 8, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants