Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Adversary Trainer accept loggers. #164

Merged
merged 212 commits into from
Jun 8, 2023
Merged

Conversation

mzweilin
Copy link
Contributor

@mzweilin mzweilin commented Jun 8, 2023

What does this PR do?

Make Adversary's Trainer accept loggers, so that we can log gradients of perturbation, etc.

Example

CUDA_VISIBLE_DEVICES=0 \
python -m mart \
experiment=CIFAR10_CNN_Adv \
fit=false \
trainer=gpu \
+trainer.limit_test_batches=1 \
+callbacks@model.modules.input_adv_test.callbacks=gradient_monitor \
+model.modules.input_adv_test.callbacks.gradient_monitor.frequency=1 \
+logger@model.modules.input_adv_test.logger=[tensorboard]
image image

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@mzweilin mzweilin requested a review from dxoigmn June 8, 2023 17:42
@mzweilin mzweilin mentioned this pull request Jun 8, 2023
13 tasks
dxoigmn
dxoigmn previously approved these changes Jun 8, 2023
Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This will be useful when debugging adversarial training.

Base automatically changed from gradient_monitor_callback to main June 8, 2023 18:34
@dxoigmn dxoigmn dismissed their stale review June 8, 2023 18:34

The base branch was changed.

@mzweilin mzweilin merged commit ed89c72 into main Jun 8, 2023
@mzweilin mzweilin deleted the log_adv_pert_gradient branch June 8, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants