Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of libsyclinterface DPCTLQueueMgr_* function related to device_context #1575

Closed
diptorupd opened this issue Mar 1, 2024 · 4 comments · Fixed by #1576
Closed

Removal of libsyclinterface DPCTLQueueMgr_* function related to device_context #1575

diptorupd opened this issue Mar 1, 2024 · 4 comments · Fixed by #1576

Comments

@diptorupd
Copy link
Contributor

diptorupd commented Mar 1, 2024

The dpctl_sycl_queue_manager is a legacy of an old design in DPEP stack where we were planning to use a single Python context manager to define the execution queue globally. DPEP software stack now uses the array API compute follows data programming model, as such the following functions are redundant and should be removed:

DPCTL_API __dpctl_give DPCTLSyclQueueRef
DPCTLQueueMgr_GetCurrentQueue(void);

DPCTL_API size_t
DPCTLQueueMgr_GetQueueStackSize(void);

DPCTL_API bool
DPCTLQueueMgr_GlobalQueueIsCurrent(void);

DPCTL_API bool
DPCTLQueueMgr_IsCurrentQueue(__dpctl_keep const DPCTLSyclQueueRef QRef);

DPCTL_API void
DPCTLQueueMgr_PopQueue(void);

DPCTL_API void
DPCTLQueueMgr_PushQueue(__dpctl_keep const DPCTLSyclQueueRef QRef);

DPCTL_API void
DPCTLQueueMgr_SetGlobalQueue(__dpctl_keep const DPCTLSyclQueueRef QRef);

On dpctl's side I believe the whole dpctl._sycl_queue_manager.pyx can be removed.

Related #11, #410

@diptorupd
Copy link
Contributor Author

@oleksandr-pavlyk @ndgrigorian If you agree, I can create a PR.

@ndgrigorian
Copy link
Collaborator

@oleksandr-pavlyk @ndgrigorian If you agree, I can create a PR.

I agree, though dpnp may need to be changed before we can merge the PR. There should be nothing blocking opening a PR in dpctl.

@oleksandr-pavlyk
Copy link
Contributor

@diptorupd Resolving this issue would also close #11

@diptorupd
Copy link
Contributor Author

@diptorupd Resolving this issue would also close #11

Of course, how can I miss that 😄

@diptorupd diptorupd changed the title Removal of libsyclinterface DPCTLQueueMgr_* functions Removal of libsyclinterface DPCTLQueueMgr_* function related to device_context Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants