Skip to content

Remove the DPCTLQueueMgr_* and device_context API from dpctl #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2024
Merged

Remove the DPCTLQueueMgr_* and device_context API from dpctl #1576

merged 6 commits into from
Mar 20, 2024

Conversation

diptorupd
Copy link
Contributor

@diptorupd diptorupd commented Mar 1, 2024 •
edited
Loading

  • Have you provided a meaningful PR description?

The DPCTLQueueMgr_* implemented a global stack in libsyclinterface to keep track of a "current queue". The stack was controlled from dpctl's Python API using dpctl.device_context. Both these features are legacy design choices that have been abandoned and no longer are required. The PR removes the DPCTLQueueMgr_*interface,dpctl.device_context` and associated functions, removes and updates test cases as needed.

  • Have you added a test, reproducer or referred to an issue with a reproducer?

Existing tests were updated.

  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Fixes #11
Fixes #410
Fixes #1575

@diptorupd diptorupd self-assigned this Mar 1, 2024
@diptorupd diptorupd marked this pull request as draft March 1, 2024 04:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_49 ran successfully.
Passed: 904
Failed: 2
Skipped: 94

@diptorupd diptorupd force-pushed the remove/device_context branch 2 times, most recently from 7b250c3 to 311844c Compare March 1, 2024 05:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_50 ran successfully.
Passed: 904
Failed: 2
Skipped: 94

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_50 ran successfully.
Passed: 904
Failed: 2
Skipped: 94

@diptorupd diptorupd force-pushed the remove/device_context branch from f437f6f to e6cc99c Compare March 1, 2024 06:25
@diptorupd diptorupd marked this pull request as ready for review March 1, 2024 06:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_52 ran successfully.
Passed: 904
Failed: 2
Skipped: 94

@coveralls
Copy link
Collaborator

coveralls commented Mar 1, 2024 •
edited
Loading

Coverage Status

coverage: 87.941% (+0.1%) from 87.832%
when pulling 653efa8 on remove/device_context
into 1fac073 on master.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_52 ran successfully.
Passed: 904
Failed: 2
Skipped: 94

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Mar 1, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_53 ran successfully.
Passed: 904
Failed: 2
Skipped: 94

oleksandr-pavlyk
oleksandr-pavlyk suggested changes Mar 16, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_135 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_135 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

oleksandr-pavlyk
oleksandr-pavlyk reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me know, but it would be best if dpnp can resolve its dependency on DPCTLQueueMgr_* before merging this.

One option is to vendor implementation of DPCTLQueueMgr_GetCurrentQueue without implementing any code to modify the stack.

@diptorupd
Copy link
Contributor Author

This looks good to me know, but it would be best if dpnp can resolve its dependency on DPCTLQueueMgr_* before merging this.

One option is to vendor implementation of DPCTLQueueMgr_GetCurrentQueue without implementing any code to modify the stack.

It is okay to wait for dpnp. Are there any blockers?

@oleksandr-pavlyk oleksandr-pavlyk self-requested a review March 19, 2024 02:46
@oleksandr-pavlyk
Copy link
Contributor

dpnp pr IntelPython/dpnp#1735 has been merged. No blockers to merge this one.

@oleksandr-pavlyk oleksandr-pavlyk merged commit cb7f18b into master Mar 20, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the remove/device_context branch March 20, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

Assignees

@diptorupd diptorupd

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@diptorupd @coveralls @oleksandr-pavlyk