Skip to content

Add support for complex numbers as kernel arguments #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diptorupd opened this issue Oct 1, 2020 · 2 comments
Open

Add support for complex numbers as kernel arguments #85

diptorupd opened this issue Oct 1, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@diptorupd
Copy link
Contributor

We will eventually need to support complexes as well.

This is not straightforward with ctypes: https://stackoverflow.com/questions/13373291/complex-number-in-ctypes

So down the road we might just introduce our own scalar type in dpctl.

Originally posted by @oleksandr-pavlyk in #80 (comment)

@diptorupd diptorupd changed the title Add support for complexe numbers as kernel arguments Add support for complex numbers as kernel arguments Oct 4, 2020
@diptorupd diptorupd added this to the gold milestone Oct 5, 2020
@diptorupd
Copy link
Contributor Author

Complex number support for numba-dpex works using current dpctl. Numba represents complex values as a 2-tuple of floats and we pass the arguments as flattened arguments to kernels. Thus, no change is needed on dpctl's side.

@ndgrigorian
Copy link
Collaborator

Reopening as, while not needed for numba-dpex, dpctl supporting complex kernel arguments would be a nice feature in the future

@ndgrigorian ndgrigorian reopened this Mar 21, 2025
@ndgrigorian ndgrigorian added the enhancement New feature or request label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants