Add support for events, programs, and kernel submission to dpctl. #80
Conversation
diptorupd
commented
Sep 30, 2020
diptorupd
commented
* New dpctl C API wrappers for sycl::event, sycl::kernel and sycl::program.
* Wrappers to create an OpenCL interoperability program from either string
or SPIR-V IL files.
* Support for submitting an interoperability kernel to a sycl::queue. We
support using either a range or an nd_range to submit the kernel.
* Event wait function is now exposed via the C API.
* New test cases for the C API.
* The dpctl Cython wrapper now supports program creation and kernel
submission.
* Other refactoring to standardize function names, attribute names, comments.
diptorupd
requested review from
PokhodenkoSA,
DrTodd13,
reazulhoque and
oleksandr-pavlyk
Add new line at end of file.
* Remove empty doxygen comment blocks
* Fix indentation
* Fix grammatical typos
diptorupd
force-pushed
the
feature/program_interfacev2
branch
from
390c747 to
e48ba39
Compare
- The default queue points to a Level-0 device is Level-0 drivers
are installed. However, we always compile our program for OpenCL
and this causes a crash if the test kernels are submitted to the
default queue.
Fixing it by selecting the GPU:0 queue that is known to be an
OpenCL device. A follow up commit will fix this in a proper way.
| cdef void DPPLQueue_Memcpy (const DPPLSyclQueueRef Q, | ||
| void *Dest, const void *Src, size_t Count) \ | ||
| except + | ||
| void *Dest, const void *Src, size_t Count) |
There was a problem hiding this comment.
@diptorupd as I remember you wanted to make Memcpy to return SyclEvent. In the next PR?
There was a problem hiding this comment.
Yes, I will open a follow up. Refer #84
| /*! | ||
| * @brief Create a Sycl program from an OpenCL SPIR-V binary file. | ||
| * | ||
| * Sycl 1.2 does expose any method to create a sycl::program from a SPIR-V IL |
There was a problem hiding this comment.
Did you mean 'does not expose'?
There was a problem hiding this comment.
good catch. Fixed now.
| * OpenCL kernel. | ||
| * | ||
| * The feature to create a Sycl kernel from a SPIR-V IL binary will be available | ||
| * in Sycl 2.0, at which point we may deprecate this function. |
There was a problem hiding this comment.
It is better to say, "at which point this function may become deprecated."
There was a problem hiding this comment.
I changed the comment. Thanks.
| * @param cgh My Param doc | ||
| * @param Arg My Param doc | ||
| */ | ||
| bool set_kernel_arg (handler &cgh, size_t idx, __dppl_keep void *Arg, |
There was a problem hiding this comment.
We will eventually need to support complexes as well.
This is not straightforward with ctypes: https://stackoverflow.com/questions/13373291/complex-number-in-ctypes
So down the road we might just introduce our own scalar type in dpctl.
There was a problem hiding this comment.
Opened #85 to track the issue.
…ctl into feature/program_interfacev2
