Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueError when trying to access an array with zero value in one of shape values #870

Closed
npolina4 opened this issue Jul 28, 2022 · 1 comment · Fixed by #871
Closed

ValueError when trying to access an array with zero value in one of shape values #870

npolina4 opened this issue Jul 28, 2022 · 1 comment · Fixed by #871

Comments

@npolina4
Copy link
Collaborator

Reproducer:

In [1]: import dpctl, dpctl.tensor as dpt
In [2]: X = dpt.empty((0,4))
In [3]: X[:, 1:3]

Output:

ValueError: Buffer can not accomodate the requested array
@oleksandr-pavlyk
Copy link
Collaborator

Also similar error for X[:, 1].

@oleksandr-pavlyk oleksandr-pavlyk changed the title ValueError when trying to access an array with zero value one of shape values ValueError when trying to access an array with zero value in one of shape values Jul 28, 2022
oleksandr-pavlyk added a commit that referenced this issue Jul 28, 2022
@oleksandr-pavlyk
Closes gh-870
c6802c3 
Offset should not be incremented if the array is found empty.

```
import dpctl.tensor as dpt
X = dpt.empty((0,4), dtype='u1')
X[:, 1]  # no longer raises ValueError
X[:, 1:3] # no longer raises ValueError
```
oleksandr-pavlyk added a commit that referenced this issue Jul 28, 2022
@oleksandr-pavlyk
Adds tests for gh-870
1f78b29
@oleksandr-pavlyk oleksandr-pavlyk mentioned this issue Jul 28, 2022
Merged
2 tasks
npolina4 added a commit that referenced this issue Jul 28, 2022
@npolina4
Adds dpctl.tensor.concat test for gh-870
cea9454
ndgrigorian pushed a commit to ndgrigorian/dpctl that referenced this issue Sep 8, 2022
@oleksandr-pavlyk @ndgrigorian
Closes IntelPythongh-870
940edd9 
Offset should not be incremented if the array is found empty.

```
import dpctl.tensor as dpt
X = dpt.empty((0,4), dtype='u1')
X[:, 1]  # no longer raises ValueError
X[:, 1:3] # no longer raises ValueError
```
ndgrigorian pushed a commit to ndgrigorian/dpctl that referenced this issue Sep 8, 2022
@oleksandr-pavlyk @ndgrigorian
Adds tests for IntelPythongh-870
ca34263
ndgrigorian pushed a commit to ndgrigorian/dpctl that referenced this issue Sep 8, 2022
@npolina4 @ndgrigorian
Adds dpctl.tensor.concat test for IntelPythongh-870
cb67e6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix getitem IntelPython/dpctl
2 participants
@oleksandr-pavlyk @npolina4