Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getitem #871

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Fix getitem #871

merged 5 commits into from
Jul 28, 2022

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Closes gh-870

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?

@npolina4 Please try extending the test for concat and confirm that the issue is fixed

@oleksandr-pavlyk
Improved exceptions msg
0561a8c
@oleksandr-pavlyk
Closes gh-870
c6802c3 
Offset should not be incremented if the array is found empty.

```
import dpctl.tensor as dpt
X = dpt.empty((0,4), dtype='u1')
X[:, 1]  # no longer raises ValueError
X[:, 1:3] # no longer raises ValueError
```
@oleksandr-pavlyk
Adds tests for gh-870
1f78b29
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/871/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jul 28, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 81.733% when pulling cea9454 on fix-getitem into c09ac88 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 880d71e into master Jul 28, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-getitem branch July 28, 2022 21:12
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError when trying to access an array with zero value in one of shape values
3 participants
@oleksandr-pavlyk @coveralls @npolina4