Feature/extra device info #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These descriptors return std::vector, further research is needed to select an implementation |
|
Continued work here diptorupd#6 |
| return unwrap(DRef)->is_gpu(); | ||
| auto D = unwrap(DRef); | ||
| if(D) { | ||
| return unwrap(DRef)->is_gpu(); |
| void DPPLSize_t_Array_Delete (__dppl_take size_t* arr) | ||
| { | ||
| delete[] arr; | ||
| } |
| ::testing::InitGoogleTest(&argc, argv); | ||
| int ret = RUN_ALL_TESTS(); | ||
| return ret; | ||
| } No newline at end of file |
| * @brief Wrapper for get_info<info::device::max_work_item_sizes(). | ||
| * | ||
| * @param DRef Opaque pointer to a sycl::device | ||
| * @return Returns the valid result if device exists else returns Null. |
There was a problem hiding this comment.
Suggested change
| * @return Returns the valid result if device exists else returns Null. | |
| * @return Returns the valid result if device exists else returns NULL. |
| return cstr_name; | ||
| auto D = unwrap(DRef); | ||
| if(D) { | ||
| auto name = unwrap(DRef)->get_info<info::device::name>(); |
| return cstr_vendor; | ||
| auto D = unwrap(DRef); | ||
| if(D) { | ||
| auto vendor = unwrap(DRef)->get_info<info::device::name>(); |
| std::strcpy (cstr_driver, driver.c_str()); | ||
| return cstr_driver; | ||
| auto D = unwrap(DRef); | ||
| if(D) { |
There was a problem hiding this comment.
Suggested change
| if(D) { | |
| if (D) { |
| @@ -0,0 +1,230 @@ | |||
| //===----- test_sycl_device_interface.cpp - DPPL-SYCL interface -*- C++ -*-===// | |||
There was a problem hiding this comment.
Suggested change
| //===----- test_sycl_device_interface.cpp - DPPL-SYCL interface -*- C++ -*-===// | |
| //===----- test_sycl_device_interface.cpp - dpctl-C_API interface -*- C++ -*-===// |
Change it in all changed files to be like in other existing files in backend.
| /// | ||
| /// \file | ||
| /// This file has unit test cases for functions defined in | ||
| /// dppl_sycl_kernel_interface.h. |
|
Closing in favor of #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes issues #113 and #81.
Sycl
deviceclass provides several info device descriptors that can be extracted usinginfo::device. This PR will expose several of the device descriptors inside dpctl C API (backends) and inside the dpctl.SyclDevice class.These attributes are needed inside Numba and possibly by other clients of dpctl to determine device capabilities.